Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(873)

Unified Diff: pkg/custom_element/lib/custom_element.dart

Issue 23055008: Making almost all dom_ methods private. Exceptions will be addressed in a later CL. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sdk/lib/html/dart2js/html_dart2js.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/custom_element/lib/custom_element.dart
diff --git a/pkg/custom_element/lib/custom_element.dart b/pkg/custom_element/lib/custom_element.dart
index 4121dbf2fc5af63c5ecac3743f59b8f2c7294d3e..ff0d64b682e11f110c1d336e48788abf929bf842 100644
--- a/pkg/custom_element/lib/custom_element.dart
+++ b/pkg/custom_element/lib/custom_element.dart
@@ -414,10 +414,6 @@ class CustomElement implements Element {
ElementList queryAll(String selectors) => host.queryAll(selectors);
- HtmlCollection get $dom_children => host.$dom_children;
-
- int get $dom_childElementCount => host.$dom_childElementCount;
-
String get className => host.className;
set className(String value) { host.className = value; }
@@ -435,10 +431,6 @@ class CustomElement implements Element {
Rect get client => host.client;
- Element get $dom_firstElementChild => host.$dom_firstElementChild;
-
- Element get $dom_lastElementChild => host.$dom_lastElementChild;
-
@deprecated
int get offsetHeight => offset.height;
@@ -476,12 +468,6 @@ class CustomElement implements Element {
host.$dom_setAttributeNS(namespaceUri, localName, value);
}
- bool $dom_hasAttributeNS(String namespaceUri, String localName) =>
- host.$dom_hasAttributeNS(namespaceUri, localName);
-
- void $dom_removeAttributeNS(String namespaceUri, String localName) =>
- host.$dom_removeAttributeNS(namespaceUri, localName);
-
Rect getBoundingClientRect() => host.getBoundingClientRect();
List<Rect> getClientRects() => host.getClientRects();
@@ -489,23 +475,12 @@ class CustomElement implements Element {
List<Node> getElementsByClassName(String name) =>
host.getElementsByClassName(name);
- List<Node> $dom_getElementsByTagName(String name) =>
- host.$dom_getElementsByTagName(name);
-
- bool $dom_hasAttribute(String name) =>
- host.$dom_hasAttribute(name);
-
List<Node> $dom_querySelectorAll(String selectors) =>
host.$dom_querySelectorAll(selectors);
- void $dom_removeAttribute(String name) =>
- host.$dom_removeAttribute(name);
-
void $dom_setAttribute(String name, String value) =>
host.$dom_setAttribute(name, value);
- get $dom_attributes => host.$dom_attributes;
-
List<Node> get $dom_childNodes => host.$dom_childNodes;
Node get firstChild => host.firstChild;
@@ -513,10 +488,8 @@ class CustomElement implements Element {
Node get lastChild => host.lastChild;
String get localName => host.localName;
- String get $dom_localName => host.$dom_localName;
String get namespaceUri => host.namespaceUri;
- String get $dom_namespaceUri => host.$dom_namespaceUri;
int get nodeType => host.nodeType;
@@ -527,16 +500,11 @@ class CustomElement implements Element {
bool dispatchEvent(Event event) => host.dispatchEvent(event);
- Node $dom_removeChild(Node oldChild) => host.$dom_removeChild(oldChild);
-
void $dom_removeEventListener(String type, EventListener listener,
[bool useCapture]) {
host.$dom_removeEventListener(type, listener, useCapture);
}
- Node $dom_replaceChild(Node newChild, Node oldChild) =>
- host.$dom_replaceChild(newChild, oldChild);
-
get xtag => host.xtag;
set xtag(value) { host.xtag = value; }
@@ -547,22 +515,6 @@ class CustomElement implements Element {
void appendHtml(String html) => host.appendHtml(html);
- void $dom_scrollIntoView([bool alignWithTop]) {
- if (alignWithTop == null) {
- host.$dom_scrollIntoView();
- } else {
- host.$dom_scrollIntoView(alignWithTop);
- }
- }
-
- void $dom_scrollIntoViewIfNeeded([bool centerIfNeeded]) {
- if (centerIfNeeded == null) {
- host.$dom_scrollIntoViewIfNeeded();
- } else {
- host.$dom_scrollIntoViewIfNeeded(centerIfNeeded);
- }
- }
-
String get regionOverset => host.regionOverset;
List<Range> getRegionFlowRanges() => host.getRegionFlowRanges();
« no previous file with comments | « no previous file | sdk/lib/html/dart2js/html_dart2js.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698