Issue 22918025: Make Invocation.positionalArguments and .namedArguments never be null.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22918025: Make Invocation.positionalArguments and .namedArguments never be null. (Closed)

Created:
7 years, 4 months ago by Lasse Reichstein Nielsen

Modified:
7 years, 3 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make Invocation.positionalArguments and .namedArguments never be null. In the cases where they were previously null, they are now an empty list or map. The list or map should always be unmodifiable, but the non-empty ones aren't yet. BUG= http://dartbug.com/6357 R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=26635

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address review comments. #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -16 lines)			Patch
M	runtime/lib/invocation_mirror_patch.dart	View		2 chunks	+8 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/lib/js_helper.dart	View		1 chunk	+7 lines, -5 lines	0 comments	Download
M	sdk/lib/core/invocation.dart	View	1	2 chunks	+14 lines, -5 lines	0 comments	Download
M	tests/language/invocation_mirror_test.dart	View		1 chunk	+2 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM. https://codereview.chromium.org/22918025/diff/1/sdk/lib/core/invocation.dart File sdk/lib/core/invocation.dart (right): https://codereview.chromium.org/22918025/diff/1/sdk/lib/core/invocation.dart#newcode21 sdk/lib/core/invocation.dart:21: * If the member is a getter, the ...

7 years, 4 months ago (2013-08-23 16:10:03 UTC) #2

Lasse Reichstein Nielsen

7 years, 3 months ago (2013-08-26 10:57:50 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r26635 (presubmit successful).

Expand Messages | Collapse Messages