Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Unified Diff: sdk/lib/_internal/lib/js_helper.dart

Issue 22918025: Make Invocation.positionalArguments and .namedArguments never be null. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address review comments. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/lib/invocation_mirror_patch.dart ('k') | sdk/lib/core/invocation.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/lib/js_helper.dart
diff --git a/sdk/lib/_internal/lib/js_helper.dart b/sdk/lib/_internal/lib/js_helper.dart
index e5ec91fb4842277ec3d15686eb66cec647f020fe..d3360a8c3ac320f4ad5ee7027f5ec5f42cf22ef3 100644
--- a/sdk/lib/_internal/lib/js_helper.dart
+++ b/sdk/lib/_internal/lib/js_helper.dart
@@ -124,21 +124,23 @@ class JSInvocationMirror implements Invocation {
bool get isAccessor => _kind != METHOD;
List get positionalArguments {
- if (isGetter) return null;
- var list = [];
+ if (isGetter) return const [];
var argumentCount =
_arguments.length - _namedArgumentNames.length;
+ if (argumentCount == 0) return const [];
+ var list = [];
for (var index = 0 ; index < argumentCount ; index++) {
list.add(_arguments[index]);
}
- return list;
+ return makeLiteralListConst(list);
}
Map<Symbol,dynamic> get namedArguments {
- if (isAccessor) return null;
- var map = new Map<Symbol, dynamic>();
+ if (isAccessor) return const <Symbol,dynamic>{};
int namedArgumentCount = _namedArgumentNames.length;
int namedArgumentsStartIndex = _arguments.length - namedArgumentCount;
+ if (namedArgumentCount == 0) return const <Symbol,dynamic>{};
+ var map = new Map<Symbol, dynamic>();
for (int i = 0; i < namedArgumentCount; i++) {
map[new _symbol_dev.Symbol.unvalidated(_namedArgumentNames[i])] =
_arguments[namedArgumentsStartIndex + i];
« no previous file with comments | « runtime/lib/invocation_mirror_patch.dart ('k') | sdk/lib/core/invocation.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698