Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Unified Diff: tests/language/invocation_mirror_test.dart

Issue 22918025: Make Invocation.positionalArguments and .namedArguments never be null. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address review comments. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/core/invocation.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/language/invocation_mirror_test.dart
diff --git a/tests/language/invocation_mirror_test.dart b/tests/language/invocation_mirror_test.dart
index 48393e9b092a49f0e2d8da626638f1d63ddf763f..6ea715d5e8f6c1f714492603af12764fe62a0f11 100644
--- a/tests/language/invocation_mirror_test.dart
+++ b/tests/language/invocation_mirror_test.dart
@@ -73,11 +73,8 @@ testInvocationMirror(Invocation im, Symbol name,
Expect.isFalse(im.isSetter, "$name:isSetter");
Expect.isFalse(im.isGetter, "$name:isGetter");
- Expect.equals(positional.length, im.positionalArguments.length);
- for (int i = 0; i < positional.length; i++) {
- Expect.equals(positional[i], im.positionalArguments[i],
- "$name:positional[$i]");
- }
+ Expect.listEquals(positional, im.positionalArguments);
+
Expect.equals(namedArguments.length, im.namedArguments.length,
"$name:#named");
namedArguments.forEach((k, v) {
« no previous file with comments | « sdk/lib/core/invocation.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698