Normalize incoming AssetID paths.

Normalize incoming AssetID paths.

BUG=https://code.google.com/p/dart/issues/detail?id=12650
R=nweiz@google.com, sigmund@google.com

Committed: https://code.google.com/p/dart/source/detail?r=26558

[Bob Nystrom, 2013-08-22 19:41:09]

I've been burned several times by creating an AssetID using a Windows file path
and having it get confused by the "\" and now Siggy hit it too, so I think
Barback should accomodate this.

We lose the ability to have a "\" in a path component on POSIX systems, but I
think that's a reasonable sacrifice.

[Siggi Cherem (dart-lang), 2013-08-22 19:50:29]

FYI - I'm still waiting for a review on my change, so if you land this, you'll
likely want to mark the pkg/polymer/ test as passing in pkg.status.

[Siggi Cherem (dart-lang), 2013-08-22 19:50:57]

On 2013/08/22 19:50:29, Siggi Cherem (dart-lang) wrote:
> FYI - I'm still waiting for a review on my change, so if you land this, you'll
> likely want to mark the pkg/polymer/ test as passing in pkg.status.

"if you land this" => "if you land this first"

[Siggi Cherem (dart-lang), 2013-08-22 19:57:43]

lgtm

[nweiz, 2013-08-22 20:57:14]

A couple nits, otherwise lgtm.

https://codereview.chromium.org/22887039/diff/5001/pkg/barback/lib/src/asset_...
File pkg/barback/lib/src/asset_id.dart (right):

https://codereview.chromium.org/22887039/diff/5001/pkg/barback/lib/src/asset_...
pkg/barback/lib/src/asset_id.dart:101: String _normalizePath(String path) {
It might be nice to assert that [path] is relative here.

https://codereview.chromium.org/22887039/diff/5001/pkg/barback/test/asset_id_...
File pkg/barback/test/asset_id_test.dart (right):

https://codereview.chromium.org/22887039/diff/5001/pkg/barback/test/asset_id_...
pkg/barback/test/asset_id_test.dart:15: 
Style nit: extra newline.

[Bob Nystrom, 2013-08-22 21:36:43]

Committed patchset #3 manually as r26558 (presubmit successful).

[Bob Nystrom, 2013-08-22 21:37:19]

https://codereview.chromium.org/22887039/diff/5001/pkg/barback/lib/src/asset_...
File pkg/barback/lib/src/asset_id.dart (right):

https://codereview.chromium.org/22887039/diff/5001/pkg/barback/lib/src/asset_...
pkg/barback/lib/src/asset_id.dart:101: String _normalizePath(String path) {
On 2013/08/22 20:57:14, nweiz wrote:
> It might be nice to assert that [path] is relative here.

Done.

https://codereview.chromium.org/22887039/diff/5001/pkg/barback/test/asset_id_...
File pkg/barback/test/asset_id_test.dart (right):

https://codereview.chromium.org/22887039/diff/5001/pkg/barback/test/asset_id_...
pkg/barback/test/asset_id_test.dart:15: 
On 2013/08/22 20:57:14, nweiz wrote:
> Style nit: extra newline.

Done.