Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1583)

Unified Diff: pkg/barback/test/asset_id_test.dart

Issue 22887039: Normalize incoming AssetID paths. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Revise. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/barback/lib/src/asset_id.dart ('k') | pkg/pkg.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/barback/test/asset_id_test.dart
diff --git a/pkg/barback/test/asset_id_test.dart b/pkg/barback/test/asset_id_test.dart
index a55bb185bdea51428b3375582b8fe218dc7a0259..16d29aee65519934d223e9f888426258745d1f64 100644
--- a/pkg/barback/test/asset_id_test.dart
+++ b/pkg/barback/test/asset_id_test.dart
@@ -11,6 +11,18 @@ import 'utils.dart';
main() {
initConfig();
+ group("constructor", () {
+ test("normalizes the path", () {
+ var id = new AssetId("app", r"path/././/to/drop/..//asset.txt");
+ expect(id.path, equals("path/to/asset.txt"));
+ });
+
+ test("normalizes backslashes to slashes in the path", () {
+ var id = new AssetId("app", r"path\to/asset.txt");
+ expect(id.path, equals("path/to/asset.txt"));
+ });
+ });
+
group("parse", () {
test("parses the package and path", () {
var id = new AssetId.parse("package|path/to/asset.txt");
@@ -29,6 +41,16 @@ main() {
test("throws if the path is empty '|'", () {
expect(() => new AssetId.parse("app|"), throwsFormatException);
});
+
+ test("normalizes the path", () {
+ var id = new AssetId.parse(r"app|path/././/to/drop/..//asset.txt");
+ expect(id.path, equals("path/to/asset.txt"));
+ });
+
+ test("normalizes backslashes to slashes in the path", () {
+ var id = new AssetId.parse(r"app|path\to/asset.txt");
+ expect(id.path, equals("path/to/asset.txt"));
+ });
});
test("equals another ID with the same package and path", () {
« no previous file with comments | « pkg/barback/lib/src/asset_id.dart ('k') | pkg/pkg.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698