Don't allow packages to depend on themselves.

Don't allow packages to depend on themselves.

BUG=https://code.google.com/p/dart/issues/detail?id=12300
R=nweiz@google.com

Committed: https://code.google.com/p/dart/source/detail?r=26543

[nweiz, 2013-08-22 00:18:21]

One suggestion, otherwise lgtm.

https://codereview.chromium.org/22825024/diff/1/sdk/lib/_internal/pub/lib/src...
File sdk/lib/_internal/pub/lib/src/pubspec.dart (right):

https://codereview.chromium.org/22825024/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/pubspec.dart:259: throw new
FormatException("Package '$name' cannot depend on itself.");
Rather than specifically including the package name for this error, perhaps we
should catch all FormatExceptions and add the pubspec name, or include it
manually in each one?

[Bob Nystrom, 2013-08-22 18:09:30]

Committed patchset #1 manually as r26543 (presubmit successful).

[Bob Nystrom, 2013-08-22 18:09:30]

Thanks!

https://codereview.chromium.org/22825024/diff/1/sdk/lib/_internal/pub/lib/src...
File sdk/lib/_internal/pub/lib/src/pubspec.dart (right):

https://codereview.chromium.org/22825024/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/pubspec.dart:259: throw new
FormatException("Package '$name' cannot depend on itself.");
On 2013/08/22 00:18:21, nweiz wrote:
> Rather than specifically including the package name for this error, perhaps we
> should catch all FormatExceptions and add the pubspec name, or include it
> manually in each one?

When one of these exceptions is thrown, the output is like:

Error parsing path/to/pubspec.yaml:
<error message here>

so the offending package is usually obvious. I thought putting the name
explicitly in this one made sense since it's the actual name that's the cause of
the error.