Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1113)

Unified Diff: sdk/lib/_internal/pub/lib/src/validator/dependency.dart

Issue 22825024: Don't allow packages to depend on themselves. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/pub/lib/src/validator/dependency.dart
diff --git a/sdk/lib/_internal/pub/lib/src/validator/dependency.dart b/sdk/lib/_internal/pub/lib/src/validator/dependency.dart
index 46e0015728d2975b0b5fbd0cf5e9153652d9c42e..1715240ca08c11e7573594b15558168ecfe03f61 100644
--- a/sdk/lib/_internal/pub/lib/src/validator/dependency.dart
+++ b/sdk/lib/_internal/pub/lib/src/validator/dependency.dart
@@ -22,14 +22,6 @@ class DependencyValidator extends Validator {
return _warnAboutSource(dependency);
}
- if (dependency.name == entrypoint.root.name) {
- warnings.add('You don\'t need to explicitly depend on your own '
- 'package.\n'
- 'Pub enables "package:${entrypoint.root.name}" imports '
- 'implicitly.');
- return new Future.value();
- }
-
if (dependency.constraint.isAny) _warnAboutConstraint(dependency);
return new Future.value();

Powered by Google App Engine
This is Rietveld 408576698