Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Side by Side Diff: sdk/lib/_internal/pub/test/validator/dependency_test.dart

Issue 22825024: Don't allow packages to depend on themselves. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 import 'dart:async'; 5 import 'dart:async';
6 import 'dart:json' as json; 6 import 'dart:json' as json;
7 7
8 import 'package:http/http.dart' as http; 8 import 'package:http/http.dart' as http;
9 import 'package:http/testing.dart'; 9 import 'package:http/testing.dart';
10 import 'package:path/path.dart' as path; 10 import 'package:path/path.dart' as path;
(...skipping 219 matching lines...) Expand 10 before | Expand all | Expand 10 after
230 } 230 }
231 } 231 }
232 } 232 }
233 })) 233 }))
234 ]).create(); 234 ]).create();
235 235
236 expectDependencyValidationWarning(' foo: ">=0.1.2 <0.1.3"'); 236 expectDependencyValidationWarning(' foo: ">=0.1.2 <0.1.3"');
237 }); 237 });
238 }); 238 });
239 }); 239 });
240
241 integration('has a hosted dependency on itself', () {
242 d.dir(appPath, [
243 d.libPubspec("test_pkg", "1.0.0", deps: {
244 "test_pkg": ">=1.0.0"
245 })
246 ]).create();
247
248 expectValidationWarning(dependency);
249 });
250 }); 240 });
251 } 241 }
OLDNEW
« sdk/lib/_internal/pub/lib/src/pubspec.dart ('K') | « sdk/lib/_internal/pub/test/pubspec_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698