Improvements to warnings on message extraction.

Improvements to warnings on message extraction.

Add warning for message names that don't match the function name, and
a warnings-are-errors command-line option.

R=efortuna@google.com

Committed: https://code.google.com/p/dart/source/detail?r=25829

[Emily Fortuna, 2013-08-06 19:31:30]

lgtm, just a few comments to consider.

https://codereview.chromium.org/22392004/diff/1/pkg/intl/lib/extract_messages...
File pkg/intl/lib/extract_messages.dart (right):

https://codereview.chromium.org/22392004/diff/1/pkg/intl/lib/extract_messages...
pkg/intl/lib/extract_messages.dart:157: print("${messageName.expression} !=
$name");
debug statement or intended?

https://codereview.chromium.org/22392004/diff/1/pkg/intl/test/message_extract...
File pkg/intl/test/message_extraction/sample_with_messages.dart (right):

https://codereview.chromium.org/22392004/diff/1/pkg/intl/test/message_extract...
pkg/intl/test/message_extraction/sample_with_messages.dart:106: // not clear if
anonymous functions are an important use case to support.
I thought we explicitly said in the design doc that we weren't going to allow
anonymous functions. Period. That was just one limitation that our users would
have to deal with.

[Alan Knight, 2013-08-06 20:00:26]

https://codereview.chromium.org/22392004/diff/1/pkg/intl/lib/extract_messages...
File pkg/intl/lib/extract_messages.dart (right):

https://codereview.chromium.org/22392004/diff/1/pkg/intl/lib/extract_messages...
pkg/intl/lib/extract_messages.dart:157: print("${messageName.expression} !=
$name");
On 2013/08/06 19:31:30, Emily Fortuna wrote:
> debug statement or intended?

Oops. Debug statement. Removed.

https://codereview.chromium.org/22392004/diff/1/pkg/intl/test/message_extract...
File pkg/intl/test/message_extraction/sample_with_messages.dart (right):

https://codereview.chromium.org/22392004/diff/1/pkg/intl/test/message_extract...
pkg/intl/test/message_extraction/sample_with_messages.dart:106: // not clear if
anonymous functions are an important use case to support.
On 2013/08/06 19:31:30, Emily Fortuna wrote:
> I thought we explicitly said in the design doc that we weren't going to allow
> anonymous functions. Period. That was just one limitation that our users would
> have to deal with. 

Excellent, I'd forgotten. Removed the TODO.

[Alan Knight, 2013-08-06 20:01:24]

Committed patchset #2 manually as r25829 (presubmit successful).