Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1125)

Unified Diff: pkg/intl/test/message_extraction/sample_with_messages.dart

Issue 22392004: Improvements to warnings on message extraction. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Changes from review Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/intl/test/message_extraction/part_of_sample_with_messages.dart ('k') | pkg/pkg.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/intl/test/message_extraction/sample_with_messages.dart
diff --git a/pkg/intl/test/message_extraction/sample_with_messages.dart b/pkg/intl/test/message_extraction/sample_with_messages.dart
index 9bad4b9ecab27139af6285f62dc858b6a9be5c7c..274cbd8977c7304f326a2d10de51bbf8c09bfcea 100644
--- a/pkg/intl/test/message_extraction/sample_with_messages.dart
+++ b/pkg/intl/test/message_extraction/sample_with_messages.dart
@@ -38,7 +38,7 @@ types(int a, String b, List c) => Intl.message("$a, $b, $c", name: 'types',
// This string will be printed with a French locale, so it will always show
// up in the French version, regardless of the current locale.
-alwaysAccented() =>
+alwaysTranslated() =>
Intl.message("This string is always translated", locale: 'fr',
name: 'alwaysTranslated');
@@ -99,14 +99,15 @@ printStuff(Intl locale) {
}
}
- // A function that is unnamed and assigned to a variable. It's also nested
+ // A function that is assigned to a variable. It's also nested
// within another function definition.
- var messageVariable = (a, b, c) => Intl.message(
+ message3(a, b, c) => Intl.message(
"Characters that need escaping, e.g slashes \\ dollars \${ (curly braces "
"are ok) and xml reserved characters <& and quotes \" "
"parameters $a, $b, and $c",
name: 'message3',
args: [a, b, c]);
+ var messageVariable = message3;
print("-------------------------------------------");
print("Printing messages for ${locale.locale}");
@@ -117,7 +118,7 @@ printStuff(Intl locale) {
print(multiLine());
print(types(1, "b", ["c", "d"]));
print(leadingQuotes());
- print(alwaysAccented());
+ print(alwaysTranslated());
print(trickyInterpolation("this"));
var thing = new YouveGotMessages();
print(thing.method());
« no previous file with comments | « pkg/intl/test/message_extraction/part_of_sample_with_messages.dart ('k') | pkg/pkg.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698