Improvements to warnings on message extraction.

pkg/intl/test/message_extraction/sample_with_messages.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * This is a program with various [Intl.message] messages. It just prints
  * all of them, and is used for testing of message extraction, translation,
  * and code generation.
  */
 library sample;
@@ skipping 20 matching lines @@
     "multiple "
     "lines.",
     name: "multiLine");
 
 // Have types on the enclosing function's arguments.
 types(int a, String b, List c) => Intl.message("$a, $b, $c", name: 'types',
     args: [a, b, c]);
 
 // This string will be printed with a French locale, so it will always show
 // up in the French version, regardless of the current locale.
-alwaysAccented() =>
+alwaysTranslated() =>
     Intl.message("This string is always translated", locale: 'fr',
         name: 'alwaysTranslated');
 
 // Test interpolation with curly braces around the expression, but it must
 // still be just a variable reference.
 trickyInterpolation(s) =>
     Intl.message("Interpolation is tricky when it ends a sentence like ${s}.",
         name: 'trickyInterpolation', args: [s]);
 
 leadingQuotes() => Intl.message("\"So-called\"", name: 'leadingQuotes');
@@ skipping 42 matching lines @@
   if (locale.locale == 'fr') {
     var badName = "thisNameIsNotInTheOriginal";
     var notInOriginal = Intl.message("foo", name: badName);
     if (notInOriginal != "foo") {
       throw "You shouldn't be able to introduce a new message in a translation";
     }
   }
 
   // A function that is unnamed and assigned to a variable. It's also nested
   // within another function definition.
-  var messageVariable = (a, b, c) => Intl.message(
+  // TODO(alanknight): This is assigned a regular name now because it conflicts
+  // with validating that the name argument matches the function name. It's
+  // not clear if anonymous functions are an important use case to support.

[Emily Fortuna, 2013/08/06 19:31:30]

I thought we explicitly said in the design doc that we weren't going to allow
anonymous functions. Period. That was just one limitation that our users would
have to deal with. 

[Alan Knight, 2013/08/06 20:00:26]

Excellent, I'd forgotten. Removed the TODO.

+  message3(a, b, c) => Intl.message(
       "Characters that need escaping, e.g slashes \\ dollars \${ (curly braces "
       "are ok) and xml reserved characters <& and quotes \" "
       "parameters $a, $b, and $c",
       name: 'message3',
       args: [a, b, c]);
+  var messageVariable = message3;
 
   print("-------------------------------------------");
   print("Printing messages for ${locale.locale}");
   Intl.withLocale(locale.locale, () {
     print(message1());
     print(message2("hello"));
     print(messageVariable(1,2,3));
     print(multiLine());
     print(types(1, "b", ["c", "d"]));
     print(leadingQuotes());
-    print(alwaysAccented());
+    print(alwaysTranslated());
     print(trickyInterpolation("this"));
     var thing = new YouveGotMessages();
     print(thing.method());
     print(thing.nonLambda());
     var x = YouveGotMessages.staticMessage();
     print(YouveGotMessages.staticMessage());
     print(notAlwaysTranslated());
     print(originalNotInBMP());
     print(escapable());
 
@@ skipping 23 matching lines @@
 var localeToUse = 'en_US';
 
 main() {
   var fr = new Intl("fr");
   var english = new Intl("en_US");
   var de = new Intl("de_DE");
   initializeMessages(fr.locale).then((_) => printStuff(fr));
   initializeMessages(de.locale).then((_) => printStuff(de));
   printStuff(english);
 }