Issue 221973004: - Handle doubles transferred in message snapshots specially.

Issue 221973004: - Handle doubles transferred in message snapshots specially. (Closed)

Created:
6 years, 8 months ago by Ivan Posva

Modified:
6 years, 8 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- Handle doubles transferred in message snapshots specially. - Do not encode doubles using integer compression. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=34681

Patch Set 2 : #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+83 lines, -36 lines)			Patch
M	runtime/vm/dart_api_message.cc	View	1	3 chunks	+8 lines, -11 lines	0 comments	Download
M	runtime/vm/raw_object_snapshot.cc	View	1	3 chunks	+4 lines, -5 lines	0 comments	Download
M	runtime/vm/snapshot.h	View	1	2 chunks	+11 lines, -0 lines	0 comments	Download
M	runtime/vm/snapshot.cc	View	1	5 chunks	+16 lines, -3 lines	0 comments	Download
M	runtime/vm/snapshot_ids.h	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
M	runtime/vm/snapshot_test.cc	View	1	5 chunks	+38 lines, -15 lines	0 comments	Download
M	runtime/vm/vm_sources.gypi	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/standalone/issue14236_source.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/standalone/issue14236_test.dart	View		Binary file		0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

kevmoo

On 2014/04/02 21:39:47, Ivan Posva wrote: DBC: _test.dart came in as binary?

6 years, 8 months ago (2014-04-02 22:45:23 UTC) #2

siva

lgtm https://codereview.chromium.org/221973004/diff/1/runtime/vm/snapshot.cc File runtime/vm/snapshot.cc (right): https://codereview.chromium.org/221973004/diff/1/runtime/vm/snapshot.cc#newcode1220 runtime/vm/snapshot.cc:1220: } We should probably consider caching the class ...

6 years, 8 months ago (2014-04-03 00:23:16 UTC) #3

Ivan Posva

Thanks! -Ivan https://codereview.chromium.org/221973004/diff/1/runtime/vm/snapshot.cc File runtime/vm/snapshot.cc (right): https://codereview.chromium.org/221973004/diff/1/runtime/vm/snapshot.cc#newcode1220 runtime/vm/snapshot.cc:1220: } On 2014/04/03 00:23:16, siva wrote: > ...

6 years, 8 months ago (2014-04-03 00:58:01 UTC) #4

Ivan Posva

Committed patchset #2 manually as r34681 (presubmit successful).

6 years, 8 months ago (2014-04-03 00:58:21 UTC) #5

Florian Schneider

6 years, 8 months ago (2014-04-04 12:29:41 UTC) #6

Message was sent while issue was closed.

On 2014/04/02 22:45:23, kevmoo wrote:
> On 2014/04/02 21:39:47, Ivan Posva wrote:
> 
> DBC: _test.dart came in as binary?

https://code.google.com/p/dart/issues/detail?id=14516

Expand Messages | Collapse Messages