- Handle doubles transferred in message snapshots specially.

runtime/vm/snapshot_test.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "include/dart_debugger_api.h"
 #include "platform/assert.h"
 #include "vm/bigint_operations.h"
 #include "vm/class_finalizer.h"
 #include "vm/dart_api_impl.h"
 #include "vm/dart_api_message.h"
@@ skipping 2071 matching lines @@
                      element->value.as_bigint);
       }
     }
     {
       // Generate a list of doubles from Dart code.
       ApiNativeScope scope;
       Dart_CObject* root = GetDeserializedDartMessage(lib, "getDoubleList");
       EXPECT_NOTNULL(root);
       EXPECT_EQ(Dart_CObject_kArray, root->type);
       EXPECT_EQ(kArrayLength, root->value.as_array.length);
-      for (int i = 0; i < kArrayLength; i++) {
-        Dart_CObject* element = root->value.as_array.values[i];
-        EXPECT_EQ(root->value.as_array.values[0], element);
+      Dart_CObject* element = root->value.as_array.values[0];
+      EXPECT_EQ(Dart_CObject_kDouble, element->type);
+      EXPECT_EQ(3.14, element->value.as_double);

[siva, 2014/04/03 00:23:16]

Maybe add a comment here to explain why the hoisting is needed for i = 0 (here
and below).

+      for (int i = 1; i < kArrayLength; i++) {
+        element = root->value.as_array.values[i];
+        // Double values are expected to not be canonicalized in messages.
+        EXPECT_NE(root->value.as_array.values[0], element);
         EXPECT_EQ(Dart_CObject_kDouble, element->type);
         EXPECT_EQ(3.14, element->value.as_double);
       }
     }
     {
       // Generate a list of Uint8Lists from Dart code.
       ApiNativeScope scope;
       Dart_CObject* root = GetDeserializedDartMessage(lib, "getTypedDataList");
       EXPECT_NOTNULL(root);
       EXPECT_EQ(Dart_CObject_kArray, root->type);
@@ skipping 24 matching lines @@
         EXPECT_EQ(0, element->value.as_typed_data.values[1]);
       }
     }
     {
       // Generate a list of objects of different types from Dart code.
       ApiNativeScope scope;
       Dart_CObject* root = GetDeserializedDartMessage(lib, "getMixedList");
       EXPECT_NOTNULL(root);
       EXPECT_EQ(Dart_CObject_kArray, root->type);
       EXPECT_EQ(kArrayLength, root->value.as_array.length);
-      for (int i = 0; i < kArrayLength; i++) {
-        Dart_CObject* element = root->value.as_array.values[i];
+      Dart_CObject* element = root->value.as_array.values[0];
+      EXPECT_EQ(Dart_CObject_kString, element->type);
+      EXPECT_STREQ("A", element->value.as_string);
+      element = root->value.as_array.values[1];
+      EXPECT_EQ(Dart_CObject_kDouble, element->type);
+      EXPECT_STREQ(2.72, element->value.as_double);
+      for (int i = 2; i < kArrayLength; i++) {
+        element = root->value.as_array.values[i];
         if ((i % 2) == 0) {
           EXPECT_EQ(root->value.as_array.values[0], element);
           EXPECT_EQ(Dart_CObject_kString, element->type);
           EXPECT_STREQ("A", element->value.as_string);
         } else {
-          EXPECT_EQ(root->value.as_array.values[1], element);
+          // Double values are expected to not be canonicalized in messages.
+          EXPECT_NE(root->value.as_array.values[1], element);
           EXPECT_EQ(Dart_CObject_kDouble, element->type);
           EXPECT_STREQ(2.72, element->value.as_double);
         }
       }
     }
     {
       // Generate a list of objects of different types from Dart code.
       ApiNativeScope scope;
       Dart_CObject* root = GetDeserializedDartMessage(lib, "getSelfRefList");
       EXPECT_NOTNULL(root);
@@ skipping 29 matching lines @@
       "}\n"
       "getBigintList() {\n"
       "  var bigint = 0x1234567890123456789012345678901234567890;\n"
       "  var list = [bigint, bigint, bigint, bigint, bigint,\n"
       "              bigint, bigint, bigint, bigint, bigint];\n"
       "  return list;\n"
       "}\n"
       "getDoubleList() {\n"
       "  var d = 3.14;\n"
       "  var list = [3.14, 3.14, 3.14, 3.14, 3.14, 3.14];\n"
-      "  list.add(3.14);;\n"
-      "  list.add(3.14);;\n"
-      "  list.add(3.14);;\n"
-      "  list.add(3.14);;\n"
+      "  list.add(3.14);\n"
+      "  list.add(3.14);\n"
+      "  list.add(3.14);\n"
+      "  list.add(3.14);\n"
       "  return list;\n"
       "}\n"
       "getTypedDataList() {\n"
       "  var byte_array = new Uint8List(256);\n"
       "  var list = [];\n"
       "  for (var i = 0; i < kArrayLength; i++) {\n"
       "    list.add(byte_array);\n"
       "  }\n"
       "  return list;\n"
       "}\n"
@@ skipping 76 matching lines @@
                      element->value.as_bigint);
       }
     }
     {
       // Generate a list of doubles from Dart code.
       ApiNativeScope scope;
       Dart_CObject* root = GetDeserializedDartMessage(lib, "getDoubleList");
       EXPECT_NOTNULL(root);
       EXPECT_EQ(Dart_CObject_kArray, root->type);
       EXPECT_EQ(kArrayLength, root->value.as_array.length);
-      for (int i = 0; i < kArrayLength; i++) {
-        Dart_CObject* element = root->value.as_array.values[i];
-        EXPECT_EQ(root->value.as_array.values[0], element);
+      Dart_CObject* element = root->value.as_array.values[0];
+      // Double values are expected to not be canonicalized in messages.
+      EXPECT_EQ(Dart_CObject_kDouble, element->type);
+      EXPECT_EQ(3.14, element->value.as_double);
+      for (int i = 1; i < kArrayLength; i++) {
+        element = root->value.as_array.values[i];
+        // Double values are expected to not be canonicalized in messages.
+        EXPECT_NE(root->value.as_array.values[0], element);
         EXPECT_EQ(Dart_CObject_kDouble, element->type);
         EXPECT_EQ(3.14, element->value.as_double);
       }
     }
     {
       // Generate a list of Uint8Lists from Dart code.
       ApiNativeScope scope;
       Dart_CObject* root = GetDeserializedDartMessage(lib, "getTypedDataList");
       EXPECT_NOTNULL(root);
       EXPECT_EQ(Dart_CObject_kArray, root->type);
@@ skipping 24 matching lines @@
         EXPECT_EQ(0, element->value.as_typed_data.values[1]);
       }
     }
     {
       // Generate a list of objects of different types from Dart code.
       ApiNativeScope scope;
       Dart_CObject* root = GetDeserializedDartMessage(lib, "getMixedList");
       EXPECT_NOTNULL(root);
       EXPECT_EQ(Dart_CObject_kArray, root->type);
       EXPECT_EQ(kArrayLength, root->value.as_array.length);
-      for (int i = 0; i < kArrayLength; i++) {
+      Dart_CObject* element = root->value.as_array.values[0];
+      EXPECT_EQ(Dart_CObject_kString, element->type);
+      EXPECT_STREQ(".", element->value.as_string);
+      element = root->value.as_array.values[1];
+      EXPECT_EQ(Dart_CObject_kDouble, element->type);
+      EXPECT_STREQ(2.72, element->value.as_double);
+      for (int i = 2; i < kArrayLength; i++) {
         Dart_CObject* element = root->value.as_array.values[i];
         if ((i % 2) == 0) {
           EXPECT_EQ(root->value.as_array.values[0], element);
           EXPECT_EQ(Dart_CObject_kString, element->type);
           EXPECT_STREQ(".", element->value.as_string);
         } else {
-          EXPECT_EQ(root->value.as_array.values[1], element);
+          // Double values are expected to not be canonicalized in messages.
+          EXPECT_NE(root->value.as_array.values[1], element);
           EXPECT_EQ(Dart_CObject_kDouble, element->type);
           EXPECT_STREQ(2.72, element->value.as_double);
         }
       }
     }
     {
       // Generate a list of objects of different types from Dart code.
       ApiNativeScope scope;
       Dart_CObject* root = GetDeserializedDartMessage(lib, "getSelfRefList");
       EXPECT_NOTNULL(root);
@@ skipping 324 matching lines @@
   result = Dart_RunLoop();
   EXPECT(Dart_IsError(result));
   EXPECT(Dart_ErrorHasException(result));
   EXPECT_SUBSTRING("Exception: nulltruefalse123456æøå3.14[]100123456789\n",
                    Dart_GetError(result));
 
   Dart_ExitScope();
 }
 
 }  // namespace dart