- Handle doubles transferred in message snapshots specially.

runtime/vm/snapshot.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/snapshot.h"
 
 #include "platform/assert.h"
 #include "vm/bigint_operations.h"
 #include "vm/bootstrap.h"
 #include "vm/class_finalizer.h"
@@ skipping 761 matching lines @@
   }
   if (object_id == kVoidType) {
     return Object::void_type();
   }
   if (object_id == kTrueValue) {
     return Bool::True().raw();
   }
   if (object_id == kFalseValue) {
     return Bool::False().raw();
   }
+  if (object_id == kDoubleObject) {
+    ASSERT(kind_ == Snapshot::kMessage);
+    return Double::New(ReadDouble());
+  }
   intptr_t class_id = ClassIdFromObjectId(object_id);
   if (IsSingletonClassId(class_id)) {
     return isolate()->class_table()->At(class_id);  // get singleton class.
   } else {
     ASSERT(Symbols::IsVMSymbolId(object_id));
     return Symbols::GetVMSymbol(object_id);  // return VM symbol.
   }
   UNREACHABLE();
   return Object::null();
 }
@@ skipping 409 matching lines @@
   // - Object that has already been written: (negative id in stream | 0x3)
 
   NoGCScope no_gc;
 
   // First check if it is a Smi (i.e not a heap object).
   if (!rawobj->IsHeapObject()) {
     Write<int64_t>(reinterpret_cast<intptr_t>(rawobj));
     return true;
   }
 
+  if ((kind_ == Snapshot::kMessage) && (rawobj->GetClassId() == kDoubleCid)) {
+    WriteVMIsolateObject(kDoubleObject);
+    RawDouble* rd = reinterpret_cast<RawDouble*>(rawobj);
+    WriteDouble(rd->ptr()->value_);
+    return true;
+  }

[siva, 2014/04/03 00:23:16]

We should probably consider caching the class id in a local variable here as it
is used multiple times in the code below.

[Ivan Posva, 2014/04/03 00:58:02]

Done.

+
   // Check if object has already been serialized, in that case just write
   // the object id out.
   uword tags = rawobj->ptr()->tags_;
   if (SerializedHeaderTag::decode(tags) == kObjectId) {
     intptr_t id = SerializedHeaderData::decode(tags);
     WriteIndexedObject(id);
     return true;
   }
 
   // Now check if it is an object from the VM isolate (NOTE: premarked objects
@@ skipping 339 matching lines @@
     NoGCScope no_gc;
     WriteObject(obj.raw());
     UnmarkAll();
   } else {
     ThrowException(exception_type(), exception_msg());
   }
 }
 
 
 }  // namespace dart