Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 219333011: Change how we provide value previews in the vm service. (Closed)

Created:
6 years, 8 months ago by turnidge
Modified:
6 years, 8 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Cutch
Visibility:
Public.

Description

Change how we provide value previews in the vm service. Rename the 'preview' property to 'valueAsString'. Rework printing so that we only add 'valueAsString' when we need it (num, String, etc.). Change ToUserCString to be a String-only method. Drop ToUserCString for lists -- it was hokey and unused. Max string length is now 1024 instead of 40. Update tests. BUG= R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=34612

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : fix tests / gen js #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -290 lines) Patch
M runtime/bin/vmservice/client/deployed/web/index.html View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index.html_bootstrap.dart.js View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index.html_bootstrap.dart.js.map View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index_devtools.html View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index_devtools.html_bootstrap.dart.js View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index_devtools.html_bootstrap.dart.js.map View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/instance_ref.html View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/instance_view.html View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/instance_ref.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/instance_ref.html View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/instance_view.html View 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/vm/object.h View 1 2 4 chunks +3 lines, -17 lines 0 comments Download
M runtime/vm/object.cc View 1 2 9 chunks +32 lines, -134 lines 0 comments Download
M runtime/vm/object_test.cc View 1 2 2 chunks +9 lines, -90 lines 0 comments Download
M runtime/vm/service.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/service_test.cc View 1 2 14 chunks +29 lines, -19 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
turnidge
6 years, 8 months ago (2014-03-31 23:18:05 UTC) #1
Cutch
lgtm
6 years, 8 months ago (2014-03-31 23:27:14 UTC) #2
turnidge
6 years, 8 months ago (2014-04-01 19:46:09 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r34612 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698