Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Side by Side Diff: runtime/vm/service.cc

Issue 219333011: Change how we provide value previews in the vm service. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: fix tests / gen js Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/object_test.cc ('k') | runtime/vm/service_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/service.h" 5 #include "vm/service.h"
6 6
7 #include "include/dart_api.h" 7 #include "include/dart_api.h"
8 #include "platform/globals.h" 8 #include "platform/globals.h"
9 9
10 #include "vm/compiler.h" 10 #include "vm/compiler.h"
(...skipping 1100 matching lines...) Expand 10 before | Expand all | Expand 10 after
1111 return true; 1111 return true;
1112 } 1112 }
1113 1113
1114 1114
1115 static void PrintPseudoNull(JSONStream* js, 1115 static void PrintPseudoNull(JSONStream* js,
1116 const char* id, 1116 const char* id,
1117 const char* preview) { 1117 const char* preview) {
1118 JSONObject jsobj(js); 1118 JSONObject jsobj(js);
1119 jsobj.AddProperty("type", "Null"); 1119 jsobj.AddProperty("type", "Null");
1120 jsobj.AddProperty("id", id); 1120 jsobj.AddProperty("id", id);
1121 jsobj.AddProperty("preview", preview); 1121 jsobj.AddProperty("valueAsString", preview);
1122 } 1122 }
1123 1123
1124 1124
1125 static RawObject* LookupObjectId(Isolate* isolate, 1125 static RawObject* LookupObjectId(Isolate* isolate,
1126 const char* arg, 1126 const char* arg,
1127 bool* error) { 1127 bool* error) {
1128 *error = false; 1128 *error = false;
1129 if (strncmp(arg, "int-", 4) == 0) { 1129 if (strncmp(arg, "int-", 4) == 0) {
1130 arg += 4; 1130 arg += 4;
1131 int64_t value = 0; 1131 int64_t value = 0;
(...skipping 754 matching lines...) Expand 10 before | Expand all | Expand 10 after
1886 while (current != NULL) { 1886 while (current != NULL) {
1887 if (strcmp(name, current->name()) == 0) { 1887 if (strcmp(name, current->name()) == 0) {
1888 return current; 1888 return current;
1889 } 1889 }
1890 current = current->next(); 1890 current = current->next();
1891 } 1891 }
1892 return NULL; 1892 return NULL;
1893 } 1893 }
1894 1894
1895 } // namespace dart 1895 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/object_test.cc ('k') | runtime/vm/service_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698