runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/instance_view.html - Issue 219333011: Change how we provide value previews in the vm service.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/instance_view.html

Issue 219333011: Change how we provide value previews in the vm service. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: fix tests / gen js Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/instance_ref.html ('k') | runtime/bin/vmservice/client/lib/src/elements/instance_ref.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/instance_view.html

diff --git a/runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/instance_view.html b/runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/instance_view.html

index f89a371e9a80ca5c6e94885dec9c7d70b2c034be..fb892fbbe3fdcf7dbf78065ac4bf161f544346ca 100644

--- a/runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/instance_view.html

+++ b/runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/instance_view.html

@@ -62,10 +62,10 @@

</class-ref>

</div>

- <template if="{{ instance['preview'] != null }}">

+ <template if="{{ instance['valueAsString'] != null }}">

- <div class="memberName">preview</div>

- <div class="memberValue">{{ instance['preview'] }}</div>

+ <div class="memberName">value</div>

+ <div class="memberValue">{{ instance['valueAsString'] }}</div>

</div>

</template>