Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issue 21832003: Fix VM implementation of CastError not to extend TypeError (issue 5280). (Closed)

Created:
7 years, 4 months ago by regis
Modified:
7 years, 4 months ago
Reviewers:
srdjan, siva
CC:
reviews_dartlang.org, zra
Visibility:
Public.

Description

Fix VM implementation of CastError not to extend TypeError (issue 5280). Remove non-compliant fields in various Error classes (issue 10144). Remove implicit constructor when patching in a constructor (issue 12217). Patch corelib Error classes instead of declaring subclasses. Update tests and status files. R=asiva@google.com, srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=25782

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+404 lines, -705 lines) Patch
M runtime/lib/corelib_sources.gypi View 1 2 1 chunk +1 line, -3 lines 0 comments Download
D runtime/lib/error.h View 1 2 1 chunk +0 lines, -19 lines 0 comments Download
D runtime/lib/error.cc View 1 2 1 chunk +0 lines, -130 lines 0 comments Download
D runtime/lib/error.dart View 1 2 1 chunk +0 lines, -119 lines 0 comments Download
A + runtime/lib/errors.cc View 2 chunks +1 line, -3 lines 0 comments Download
M runtime/lib/errors_patch.dart View 1 2 1 chunk +112 lines, -0 lines 0 comments Download
M runtime/lib/stacktrace.cc View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/code_generator.h View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M runtime/vm/code_generator.cc View 1 2 1 chunk +0 lines, -30 lines 0 comments Download
M runtime/vm/exceptions.cc View 1 2 4 chunks +18 lines, -22 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler_ia32.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler_mips.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler_x64.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/object.cc View 1 2 4 chunks +26 lines, -5 lines 0 comments Download
M runtime/vm/symbols.h View 1 2 2 chunks +7 lines, -6 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 2 2 chunks +17 lines, -4 lines 0 comments Download
M tests/language/generic_test.dart View 1 2 1 chunk +5 lines, -8 lines 0 comments Download
M tests/language/language.status View 1 2 2 chunks +1 line, -3 lines 0 comments Download
M tests/language/language_analyzer.status View 1 2 2 chunks +1 line, -3 lines 0 comments Download
M tests/language/named_parameters_type_test.dart View 1 2 1 chunk +9 lines, -6 lines 0 comments Download
M tests/language/positional_parameters_type_test.dart View 1 2 1 chunk +12 lines, -4 lines 0 comments Download
M tests/language/type_cast_vm_test.dart View 1 2 6 chunks +26 lines, -26 lines 0 comments Download
M tests/language/type_vm_test.dart View 1 2 15 chunks +157 lines, -283 lines 0 comments Download
M tests/lib/analyzer/analyze_tests.status View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M tests/standalone/assert_test.dart View 1 2 3 chunks +8 lines, -18 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
regis
7 years, 4 months ago (2013-08-02 23:59:05 UTC) #1
srdjan
lgtm
7 years, 4 months ago (2013-08-05 17:31:00 UTC) #2
siva
lgtm https://codereview.chromium.org/21832003/diff/14001/tests/language/generic_test.dart File tests/language/generic_test.dart (right): https://codereview.chromium.org/21832003/diff/14001/tests/language/generic_test.dart#newcode57 tests/language/generic_test.dart:57: } on TypeError catch (error, stacktrace) { I ...
7 years, 4 months ago (2013-08-05 17:57:52 UTC) #3
regis
Thanks! https://codereview.chromium.org/21832003/diff/14001/tests/language/generic_test.dart File tests/language/generic_test.dart (right): https://codereview.chromium.org/21832003/diff/14001/tests/language/generic_test.dart#newcode57 tests/language/generic_test.dart:57: } on TypeError catch (error, stacktrace) { On ...
7 years, 4 months ago (2013-08-05 18:34:44 UTC) #4
regis
7 years, 4 months ago (2013-08-05 18:35:17 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r25782 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698