Fix VM implementation of CastError not to extend TypeError (issue 5280).

runtime/vm/object.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/object.h"
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "vm/assembler.h"
 #include "vm/cpu.h"
@@ skipping 128 matching lines @@
 
 
 // The following functions are marked as invisible, meaning they will be hidden
 // in the stack trace.
 // (Library, class name, method name)
 #define INVISIBLE_LIST(V)                                                      \
   V(CoreLibrary, Object, _noSuchMethod)                                        \
   V(CoreLibrary, Object, _as)                                                  \
   V(CoreLibrary, Object, _instanceOf)                                          \
   V(CoreLibrary, _ObjectArray, _ObjectArray.)                                  \
-  V(CoreLibrary, _AssertionErrorImplementation, _throwNew)                     \
-  V(CoreLibrary, _TypeErrorImplementation, _throwNew)                          \
-  V(CoreLibrary, _FallThroughErrorImplementation, _throwNew)                   \
-  V(CoreLibrary, _AbstractClassInstantiationErrorImplementation, _throwNew)    \
+  V(CoreLibrary, AssertionError, _throwNew)                                    \
+  V(CoreLibrary, TypeError, _throwNew)                                         \
+  V(CoreLibrary, FallThroughError, _throwNew)                                  \
+  V(CoreLibrary, AbstractClassInstantiationError, _throwNew)                   \
   V(CoreLibrary, NoSuchMethodError, _throwNew)                                 \
   V(CoreLibrary, int, _throwFormatException)                                   \
   V(CoreLibrary, int, _parse)                                                  \
   V(CoreLibrary, StackTrace, _setupFullStackTrace)                             \
 
 
 static void MarkFunctionAsInvisible(const Library& lib,
                                     const char* class_name,
                                     const char* function_name) {
   ASSERT(!lib.IsNull());
@@ skipping 1755 matching lines @@
 
   Array& orig_list = Array::Handle(functions());
   intptr_t orig_len = orig_list.Length();
   Array& patch_list = Array::Handle(patch.functions());
   intptr_t patch_len = patch_list.Length();
 
   // TODO(iposva): Verify that only patching existing methods and adding only
   // new private methods.
   Function& func = Function::Handle();
   Function& orig_func = Function::Handle();
+  // Lookup the original implicit constructor, if any.
+  member_name = Name();
+  member_name = String::Concat(member_name, Symbols::Dot());
+  Function& orig_implicit_ctor = Function::Handle(LookupFunction(member_name));
+  if (!orig_implicit_ctor.IsNull() &&
+      !orig_implicit_ctor.IsImplicitConstructor()) {
+    // Not an implicit constructor, but a user declared one.
+    orig_implicit_ctor = Function::null();
+  }
   const GrowableObjectArray& new_functions = GrowableObjectArray::Handle(
       GrowableObjectArray::New(orig_len));
   for (intptr_t i = 0; i < orig_len; i++) {
     orig_func ^= orig_list.At(i);
     member_name ^= orig_func.name();
     func = patch.LookupFunction(member_name);
     if (func.IsNull()) {
       // Non-patched function is preserved, all patched functions are added in
       // the loop below.
-      new_functions.Add(orig_func);
+      // However, an implicitly created constructor should not be preserved if
+      // the patch provides a constructor or a factory. Wait for now.
+      if (orig_func.raw() != orig_implicit_ctor.raw()) {
+        new_functions.Add(orig_func);
+      }
     } else if (!func.HasCompatibleParametersWith(orig_func) &&
                !(func.IsFactory() && orig_func.IsConstructor() &&
                  (func.num_fixed_parameters() + 1 ==
                   orig_func.num_fixed_parameters()))) {
       return FormatPatchError("mismatched parameters: %s", member_name);
     }
   }
   for (intptr_t i = 0; i < patch_len; i++) {
     func ^= patch_list.At(i);
+    if (func.IsConstructor() || func.IsFactory()) {
+      // Do not preserve the original implicit constructor, if any.
+      orig_implicit_ctor = Function::null();
+    }
     func.set_owner(patch_class);
     new_functions.Add(func);
   }
+  if (!orig_implicit_ctor.IsNull()) {
+    // Preserve the original implicit constructor.
+    new_functions.Add(orig_implicit_ctor);
+  }
   Array& new_list = Array::Handle(Array::MakeArray(new_functions));
   SetFunctions(new_list);
 
   // Merge the two list of fields. Raise an error when duplicates are found or
   // when a public field is being added.
   orig_list = fields();
   orig_len = orig_list.Length();
   patch_list = patch.fields();
   patch_len = patch_list.Length();
 
@@ skipping 12583 matching lines @@
 }
 
 
 void MirrorReference::PrintToJSONStream(JSONStream* stream, bool ref) const {
   stream->OpenObject();
   stream->CloseObject();
 }
 
 
 }  // namespace dart