Fix VM implementation of CastError not to extend TypeError (issue 5280).

runtime/vm/code_generator.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/code_generator.h"
 
 #include "vm/assembler.h"
 #include "vm/ast.h"
 #include "vm/bigint_operations.h"
 #include "vm/code_patcher.h"
@@ skipping 635 matching lines @@
                                         dst_name, malformed_error_message);
     UNREACHABLE();
   }
   UpdateTypeTestCache(src_instance, dst_type,
                       dst_instantiator, instantiator_type_arguments,
                       Bool::True(), cache);
   arguments.SetReturn(src_instance);
 }
 
 
-// Test whether a formal parameter was defined by a passed-in argument.
-// Arg0: formal parameter index as Smi.
-// Arg1: formal parameter name as Symbol.
-// Arg2: arguments descriptor array.
-// Return value: true or false.
-DEFINE_RUNTIME_ENTRY(ArgumentDefinitionTest, 3) {
-  ASSERT(arguments.ArgCount() ==
-         kArgumentDefinitionTestRuntimeEntry.argument_count());
-  const Smi& param_index = Smi::CheckedHandle(arguments.ArgAt(0));
-  const String& param_name = String::CheckedHandle(arguments.ArgAt(1));
-  ASSERT(param_name.IsSymbol());
-  const Array& arg_desc_array = Array::CheckedHandle(arguments.ArgAt(2));
-  ArgumentsDescriptor arg_desc(arg_desc_array);
-  const intptr_t num_pos_args = arg_desc.PositionalCount();
-  // Check if the formal parameter is defined by a positional argument.
-  bool is_defined = num_pos_args > param_index.Value();
-  if (!is_defined) {
-    // Check if the formal parameter is defined by a named argument.
-    const intptr_t num_named_args = arg_desc.NamedCount();
-    for (intptr_t i = 0; i < num_named_args; i++) {
-      if (arg_desc.MatchesNameAt(i, param_name)) {
-        is_defined = true;
-        break;
-      }
-    }
-  }
-  arguments.SetReturn(is_defined ? Bool::True() : Bool::False());
-}
-
-
 // Report that the type of the given object is not bool in conditional context.
 // Arg0: bad object.
 // Return value: none, throws a TypeError.
 DEFINE_RUNTIME_ENTRY(ConditionTypeError, 1) {
   ASSERT(arguments.ArgCount() ==
       kConditionTypeErrorRuntimeEntry.argument_count());
   const intptr_t location = GetCallerLocation();
   const Instance& src_instance = Instance::CheckedHandle(arguments.ArgAt(0));
   ASSERT(src_instance.IsNull() || !src_instance.IsBool());
   const Type& bool_interface = Type::Handle(Type::BoolType());
@@ skipping 1201 matching lines @@
 //   Arg1: Value that is being stored.
 DEFINE_RUNTIME_ENTRY(UpdateFieldCid, 2) {
   ASSERT(arguments.ArgCount() == kUpdateFieldCidRuntimeEntry.argument_count());
   const Field& field = Field::CheckedHandle(arguments.ArgAt(0));
   const Object& value = Object::Handle(arguments.ArgAt(1));
 
   field.UpdateCid(value.GetClassId());
 }
 
 }  // namespace dart