Issue 213203007: test_options tweak post json fix

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 213203007: test_options tweak post json fix (Closed)

Created:
6 years, 9 months ago by kevmoo

Modified:
6 years, 8 months ago

Reviewers:
ricow1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

test_options tweak post json fix R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=34560

Patch Set 1 #

Total comments: 2

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	tools/testing/dart/test_options.dart	View		2 chunks	+3 lines, -3 lines	2 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ricow1

https://codereview.chromium.org/213203007/diff/1/tools/testing/dart/test_options.dart File tools/testing/dart/test_options.dart (right): https://codereview.chromium.org/213203007/diff/1/tools/testing/dart/test_options.dart#newcode13 tools/testing/dart/test_options.dart:13: const List<String> defaultTestSelectors = why are you removing const ...

6 years, 9 months ago (2014-03-27 06:52:04 UTC) #2

kevmoo

6 years, 9 months ago (2014-03-27 17:27:19 UTC) #3

kevmoo

6 years, 8 months ago (2014-03-31 16:14:24 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r34560 (presubmit successful).

Expand Messages | Collapse Messages