Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Unified Diff: tools/testing/dart/test_options.dart

Issue 213203007: test_options tweak post json fix (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_options.dart
diff --git a/tools/testing/dart/test_options.dart b/tools/testing/dart/test_options.dart
index f84b3e96b329989ce09f990e21f389e10474a758..ac50a50f98f28ac26ab1d5b419c3e886cf6d3278 100644
--- a/tools/testing/dart/test_options.dart
+++ b/tools/testing/dart/test_options.dart
@@ -10,9 +10,9 @@ import "test_suite.dart";
import "compiler_configuration.dart" show CompilerConfiguration;
import "runtime_configuration.dart" show RuntimeConfiguration;
-List<String> defaultTestSelectors =
+const List<String> defaultTestSelectors =
ricow1 2014/03/27 06:52:04 why are you removing const here
kevmoo 2014/03/27 17:27:19 I'm not removing const. I'm ADDING it. :-)
const ['samples', 'standalone', 'corelib', 'co19', 'language',
- 'isolate', 'vm', 'html', 'json', 'benchmark_smoke',
+ 'isolate', 'vm', 'html', 'benchmark_smoke',
'utils', 'lib', 'pkg', 'analyze_library'];
/**
@@ -675,7 +675,7 @@ Note: currently only implemented for dart2js.''',
var selectors = configuration['selectors'];
if (selectors is !Map) {
if (selectors == null) {
- selectors = new List.from(defaultTestSelectors);
+ selectors = defaultTestSelectors;
}
Map<String, RegExp> selectorMap = new Map<String, RegExp>();
for (var i = 0; i < selectors.length; i++) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698