test_options tweak post json fix

tools/testing/dart/test_options.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test_options_parser;
 
 import "dart:io";
 import "drt_updater.dart";
 import "test_suite.dart";
 import "compiler_configuration.dart" show CompilerConfiguration;
 import "runtime_configuration.dart" show RuntimeConfiguration;
 
-List<String> defaultTestSelectors =
+const List<String> defaultTestSelectors =

[ricow1, 2014/03/27 06:52:04]

why are you removing const here

[kevmoo, 2014/03/27 17:27:19]

I'm not removing const. I'm ADDING it. :-)

     const ['samples', 'standalone', 'corelib', 'co19', 'language',
-           'isolate', 'vm', 'html', 'json', 'benchmark_smoke',
+           'isolate', 'vm', 'html', 'benchmark_smoke',
            'utils', 'lib', 'pkg', 'analyze_library'];
 
 /**
  * Specification of a single test option.
  *
  * The name of the specification is used as the key for the option in
  * the Map returned from the [TestOptionParser] parse method.
  */
 class _TestOptionSpecification {
   _TestOptionSpecification(this.name,
@@ skipping 642 matching lines @@
     // Allow suppression that is valid for all ie versions
     configuration['ie'] = runtime.startsWith('ie');
 
     // Expand the test selectors into a suite name and a simple
     // regular expressions to be used on the full path of a test file
     // in that test suite. If no selectors are explicitly given use
     // the default suite patterns.
     var selectors = configuration['selectors'];
     if (selectors is !Map) {
       if (selectors == null) {
-        selectors = new List.from(defaultTestSelectors);
+        selectors = defaultTestSelectors;
       }
       Map<String, RegExp> selectorMap = new Map<String, RegExp>();
       for (var i = 0; i < selectors.length; i++) {
         var pattern = selectors[i];
         var suite = pattern;
         var slashLocation = pattern.indexOf('/');
         if (slashLocation != -1) {
           suite = pattern.substring(0, slashLocation);
           pattern = pattern.substring(slashLocation + 1);
           pattern = pattern.replaceAll('*', '.*');
@@ skipping 120 matching lines @@
         return option;
       }
     }
     print('Unknown test option $name');
     exit(1);
   }
 
 
   List<_TestOptionSpecification> _options;
 }