Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 209983002: Be sure we to read all bytes requested, in GetRandomBytes. (Closed)

Created:
6 years, 9 months ago by Anders Johnsen
Modified:
6 years, 9 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Be sure we to read all bytes requested, in GetRandomBytes. BUG=https://code.google.com/p/dart/issues/detail?id=17723 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=34305

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M runtime/bin/crypto_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/bin/crypto_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/crypto_macos.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Anders Johnsen
6 years, 9 months ago (2014-03-24 13:38:55 UTC) #1
Søren Gjesse
LGTM
6 years, 9 months ago (2014-03-24 13:40:14 UTC) #2
Anders Johnsen
6 years, 9 months ago (2014-03-24 13:40:36 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r34305 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698