runtime/bin/crypto_linux.cc - Issue 209983002: Be sure we to read all bytes requested, in GetRandomBytes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/crypto_linux.cc

Issue 209983002: Be sure we to read all bytes requested, in GetRandomBytes. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/bin/crypto_linux.cc

diff --git a/runtime/bin/crypto_linux.cc b/runtime/bin/crypto_linux.cc

index 905bf77481a62744282c285f810c79d76f96eb43..643af6cf5014c70dedc4006f9489d2944227b45c 100644

--- a/runtime/bin/crypto_linux.cc

+++ b/runtime/bin/crypto_linux.cc

@@ -19,7 +19,7 @@ namespace bin {

bool Crypto::GetRandomBytes(intptr_t count, uint8_t* buffer) {

intptr_t fd = TEMP_FAILURE_RETRY(open("/dev/urandom", O_RDONLY));

if (fd < 0) return false;

- intptr_t bytes_read = TEMP_FAILURE_RETRY(read(fd, buffer, count));

+ intptr_t bytes_read = FDUtils::ReadFromBlocking(fd, buffer, count);

VOID_TEMP_FAILURE_RETRY(close(fd));

return bytes_read == count;

}

« no previous file with comments | « runtime/bin/crypto_android.cc ('k') | runtime/bin/crypto_macos.cc » ('j') | no next file with comments »