Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Unified Diff: runtime/bin/crypto_macos.cc

Issue 209983002: Be sure we to read all bytes requested, in GetRandomBytes. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/crypto_linux.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/crypto_macos.cc
diff --git a/runtime/bin/crypto_macos.cc b/runtime/bin/crypto_macos.cc
index 36020d4a7f307e2271176e681c37915f41ade1fb..d808d416b608a571c807fa9fcfc6f97ae6396d37 100644
--- a/runtime/bin/crypto_macos.cc
+++ b/runtime/bin/crypto_macos.cc
@@ -20,8 +20,8 @@ namespace bin {
bool Crypto::GetRandomBytes(intptr_t count, uint8_t* buffer) {
intptr_t fd = TEMP_FAILURE_RETRY(open("/dev/urandom", O_RDONLY));
if (fd < 0) return false;
- intptr_t bytes_read = read(fd, buffer, count);
- close(fd);
+ intptr_t bytes_read = FDUtils::ReadFromBlocking(fd, buffer, count);
+ VOID_TEMP_FAILURE_RETRY(close(fd));
return bytes_read == count;
}
« no previous file with comments | « runtime/bin/crypto_linux.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698