Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1321)

Issue 2009163003: Add support for --dart2js-path and --dart2js-args. (Closed)

Created:
4 years, 7 months ago by nweiz
Modified:
4 years, 6 months ago
Reviewers:
Chris Bracken
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add support for --dart2js-path and --dart2js-args. These are only intended to be used by Google's internal test runner. Their API is not public nor is it guaranteed to be stable. They're being moved into the external repository to ease the pain of merging. R=cbracken@google.com Committed: https://github.com/dart-lang/test/commit/3ee3b80b1556f624dff58b05bb79f46edc694ea6

Patch Set 1 #

Patch Set 2 : Code review changes #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -22 lines) Patch
M lib/src/runner/browser/compiler_pool.dart View 4 chunks +11 lines, -14 lines 0 comments Download
M lib/src/runner/browser/platform.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/runner/configuration.dart View 1 2 8 chunks +21 lines, -0 lines 0 comments Download
M lib/src/runner/configuration/args.dart View 1 2 3 chunks +17 lines, -6 lines 0 comments Download
M pubspec.yaml View 1 1 chunk +1 line, -1 line 0 comments Download
M test/runner/configuration/configuration_test.dart View 9 chunks +34 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
nweiz
4 years, 7 months ago (2016-05-25 22:15:44 UTC) #1
nweiz
Code review changes
4 years, 7 months ago (2016-05-25 22:18:35 UTC) #2
Chris Bracken
lgtm
4 years, 6 months ago (2016-06-05 00:00:06 UTC) #3
nweiz
4 years, 6 months ago (2016-06-06 22:29:56 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
3ee3b80b1556f624dff58b05bb79f46edc694ea6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698