Add support for --dart2js-path and --dart2js-args.

test/runner/configuration/configuration_test.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 @TestOn("vm")
 
 import 'package:boolean_selector/boolean_selector.dart';
 import 'package:path/path.dart' as p;
 import 'package:test/test.dart';
 
@@ skipping 12 matching lines @@
         expect(merged.version, isFalse);
         expect(merged.verboseTrace, isFalse);
         expect(merged.jsTrace, isFalse);
         expect(merged.skip, isFalse);
         expect(merged.skipReason, isNull);
         expect(merged.pauseAfterLoad, isFalse);
         expect(merged.color, equals(canUseSpecialChars));
         expect(merged.shardIndex, isNull);
         expect(merged.totalShards, isNull);
         expect(merged.packageRoot, equals(p.join(p.current, 'packages')));
+        expect(merged.dart2jsPath, equals(p.join(sdkDir, 'bin', 'dart2js')));
         expect(merged.reporter, equals(defaultReporter));
         expect(merged.pubServeUrl, isNull);
         expect(merged.platforms, equals([TestPlatform.vm]));
         expect(merged.paths, equals(["test"]));
       });
 
       test("if only the old configuration's is defined, uses it", () {
         var merged = new Configuration(
                 help: true,
                 version: true,
                 verboseTrace: true,
                 jsTrace: true,
                 skip: true,
                 skipReason: "boop",
                 pauseAfterLoad: true,
                 color: true,
                 shardIndex: 3,
                 totalShards: 10,
                 packageRoot: "root",
+                dart2jsPath: "/tmp/dart2js",
                 reporter: "json",
                 pubServePort: 1234,
                 platforms: [TestPlatform.chrome],
                 paths: ["bar"])
             .merge(new Configuration());
 
         expect(merged.help, isTrue);
         expect(merged.version, isTrue);
         expect(merged.verboseTrace, isTrue);
         expect(merged.jsTrace, isTrue);
         expect(merged.skip, isTrue);
         expect(merged.skipReason, equals("boop"));
         expect(merged.pauseAfterLoad, isTrue);
         expect(merged.color, isTrue);
         expect(merged.shardIndex, equals(3));
         expect(merged.totalShards, equals(10));
         expect(merged.packageRoot, equals("root"));
+        expect(merged.dart2jsPath, equals("/tmp/dart2js"));
         expect(merged.reporter, equals("json"));
         expect(merged.pubServeUrl.port, equals(1234));
         expect(merged.platforms, equals([TestPlatform.chrome]));
         expect(merged.paths, equals(["bar"]));
       });
 
       test("if only the new configuration's is defined, uses it", () {
         var merged = new Configuration().merge(new Configuration(
             help: true,
             version: true,
             verboseTrace: true,
             jsTrace: true,
             skip: true,
             skipReason: "boop",
             pauseAfterLoad: true,
             color: true,
             shardIndex: 3,
             totalShards: 10,
             packageRoot: "root",
+            dart2jsPath: "/tmp/dart2js",
             reporter: "json",
             pubServePort: 1234,
             platforms: [TestPlatform.chrome],
             paths: ["bar"]));
 
         expect(merged.help, isTrue);
         expect(merged.version, isTrue);
         expect(merged.verboseTrace, isTrue);
         expect(merged.jsTrace, isTrue);
         expect(merged.skip, isTrue);
         expect(merged.skipReason, equals("boop"));
         expect(merged.pauseAfterLoad, isTrue);
         expect(merged.color, isTrue);
         expect(merged.shardIndex, equals(3));
         expect(merged.totalShards, equals(10));
         expect(merged.packageRoot, equals("root"));
+        expect(merged.dart2jsPath, equals("/tmp/dart2js"));
         expect(merged.reporter, equals("json"));
         expect(merged.pubServeUrl.port, equals(1234));
         expect(merged.platforms, equals([TestPlatform.chrome]));
         expect(merged.paths, equals(["bar"]));
       });
 
       test("if the two configurations conflict, uses the new configuration's "
           "values", () {
         var older = new Configuration(
             help: true,
             version: false,
             verboseTrace: true,
             jsTrace: false,
             skip: true,
             skipReason: "foo",
             pauseAfterLoad: true,
             color: false,
             shardIndex: 2,
             totalShards: 4,
             packageRoot: "root",
+            dart2jsPath: "/tmp/dart2js",
             reporter: "json",
             pubServePort: 1234,
             platforms: [TestPlatform.chrome],
             paths: ["bar"]);
         var newer = new Configuration(
             help: false,
             version: true,
             verboseTrace: false,
             jsTrace: true,
             skip: true,
             skipReason: "bar",
             pauseAfterLoad: false,
             color: true,
             shardIndex: 3,
             totalShards: 10,
             packageRoot: "boot",
+            dart2jsPath: "../dart2js",
             reporter: "compact",
             pubServePort: 5678,
             platforms: [TestPlatform.dartium],
             paths: ["blech"]);
         var merged = older.merge(newer);
 
         expect(merged.help, isFalse);
         expect(merged.version, isTrue);
         expect(merged.verboseTrace, isFalse);
         expect(merged.jsTrace, isTrue);
         expect(merged.skipReason, equals("bar"));
         expect(merged.pauseAfterLoad, isFalse);
         expect(merged.color, isTrue);
         expect(merged.shardIndex, equals(3));
         expect(merged.totalShards, equals(10));
         expect(merged.packageRoot, equals("boot"));
+        expect(merged.dart2jsPath, equals("../dart2js"));
         expect(merged.reporter, equals("compact"));
         expect(merged.pubServeUrl.port, equals(5678));
         expect(merged.platforms, equals([TestPlatform.dartium]));
         expect(merged.paths, equals(["blech"]));
       });
     });
 
     group("for testOn", () {
       test("if neither is defined, preserves the default", () {
         var merged = new Configuration().merge(new Configuration());
@@ skipping 147 matching lines @@
       test("if the merge conflicts, prefers the new value", () {
         var older = new Configuration(
             timeout: new Timeout(new Duration(seconds: 1)));
         var newer = new Configuration(
             timeout: new Timeout(new Duration(seconds: 2)));
         var merged = older.merge(newer);
         expect(merged.timeout, equals(new Timeout(new Duration(seconds: 2))));
       });
     });
 
+    group("for dart2jsArgs", () {
+      test("if neither is defined, preserves the default", () {
+        var merged = new Configuration().merge(new Configuration());
+        expect(merged.dart2jsArgs, isEmpty);
+      });
+
+      test("if only the old configuration's is defined, uses it", () {
+        var merged = new Configuration(dart2jsArgs: ["--foo", "--bar"])
+            .merge(new Configuration());
+        expect(merged.dart2jsArgs, equals(["--foo", "--bar"]));
+      });
+
+      test("if only the new configuration's is defined, uses it", () {
+        var merged = new Configuration()
+            .merge(new Configuration(dart2jsArgs: ["--foo", "--bar"]));
+        expect(merged.dart2jsArgs, equals(["--foo", "--bar"]));
+      });
+
+      test("if both are defined, concatenates them", () {
+        var older = new Configuration(dart2jsArgs: ["--foo", "--bar"]);
+        var newer = new Configuration(dart2jsArgs: ["--baz"]);
+        var merged = older.merge(newer);
+        expect(merged.dart2jsArgs, equals(["--foo", "--bar", "--baz"]));
+      });
+    });
+
     group("for config maps", () {
       test("merges each nested configuration", () {
         var merged = new Configuration(
           tags: {
             new BooleanSelector.parse("foo"):
                 new Configuration(verboseTrace: true),
             new BooleanSelector.parse("bar"): new Configuration(jsTrace: true)
           },
           onPlatform: {
             new PlatformSelector.parse("vm"):
@@ skipping 101 matching lines @@
             .merge(new Configuration());
 
         expect(configuration.presets, isEmpty);
         expect(configuration.chosenPresets, equals(["foo"]));
         expect(configuration.knownPresets, equals(["foo"]));
         expect(configuration.verboseTrace, isTrue);
       });
     });
   });
 }