Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1147)

Unified Diff: lib/src/runner/configuration/args.dart

Issue 2009163003: Add support for --dart2js-path and --dart2js-args. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/runner/configuration.dart ('k') | pubspec.yaml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/runner/configuration/args.dart
diff --git a/lib/src/runner/configuration/args.dart b/lib/src/runner/configuration/args.dart
index 48ac46f8f492286be33bd3d8100a3e7440e39891..ff318e28ee6a41d1773854aebee7c3880119b605 100644
--- a/lib/src/runner/configuration/args.dart
+++ b/lib/src/runner/configuration/args.dart
@@ -85,12 +85,6 @@ final ArgParser _parser = (() {
'Currently only supported for browser tests.',
negatable: false);
- // These are used by the internal Google test runner, so they're hidden from
- // the --help output but still supported as stable API surface. See
- // [Configuration.shardIndex] for details on their semantics.
- parser.addOption("shard-index", hide: true);
- parser.addOption("total-shards", hide: true);
-
parser.addSeparator("======== Output");
parser.addOption("reporter",
abbr: 'r',
@@ -109,6 +103,21 @@ final ArgParser _parser = (() {
parser.addFlag("color",
help: 'Whether to use terminal colors.\n(auto-detected by default)');
+ /// The following options are used only by the internal Google test runner.
+ /// They're hidden and not supported as stable API surface outside Google.
+
+ parser.addOption("dart2js-path",
+ help: 'The path to the dart2js executable.', hide: true);
+ parser.addOption("dart2js-args",
+ help: 'Extra arguments to pass to dart2js.',
+ allowMultiple: true, hide: true);
+ parser.addOption("total-shards",
+ help: 'The total number of invocations of the test runner being run.',
+ hide: true);
+ parser.addOption("shard-index",
+ help: 'The index of this test runner invocation (of --total-shards).',
+ hide: true);
+
return parser;
})();
@@ -175,6 +184,8 @@ class _Parser {
pauseAfterLoad: _ifParsed('pause-after-load'),
color: _ifParsed('color'),
packageRoot: _ifParsed('package-root'),
+ dart2jsPath: _ifParsed('dart2js-path'),
+ dart2jsArgs: _ifParsed('dart2js-args') as List<String>,
reporter: _ifParsed('reporter'),
pubServePort: _parseOption('pub-serve', int.parse),
concurrency: _parseOption('concurrency', int.parse),
« no previous file with comments | « lib/src/runner/configuration.dart ('k') | pubspec.yaml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698