Rework library and class view pages.

Rework library and class view pages.

Add expression evaluation support for libraries and classes.

R=johnmccutchan@google.com

Committed: https://code.google.com/p/dart/source/detail?r=33755

[Cutch, 2014-03-13 18:16:40]

lgtm w/ comment

https://codereview.chromium.org/199363002/diff/20001/runtime/bin/vmservice/cl...
File runtime/bin/vmservice/client/lib/src/elements/function_ref.html (right):

https://codereview.chromium.org/199363002/diff/20001/runtime/bin/vmservice/cl...
runtime/bin/vmservice/client/lib/src/elements/function_ref.html:8:
<template><template if="{{ qualified && ref['parent'] == null &&
ref['class']['name'] != '::' }}"><class-ref ref="{{ ref['class']
}}"></class-ref>.</template><template if="{{ qualified && ref['parent'] != null
}}"><function-ref ref="{{ ref['parent'] }}" qualified="{{ true
}}"></function-ref>.</template><a href="{{ url }}">{{ name }}</a></template>
Could you move this code into methods on FunctionRefElement? It will make the
template read better.

<template if="{{ qualified && classQualified}}">
<class-ref ref="{{ ref['class'] }}"></class-ref>.
</template>

...

https://codereview.chromium.org/199363002/diff/20001/runtime/vm/service_test.cc
File runtime/vm/service_test.cc (right):

https://codereview.chromium.org/199363002/diff/20001/runtime/vm/service_test....
runtime/vm/service_test.cc:658: // Evaluate an expression from class A.
Glad that this is being tested.

[turnidge, 2014-03-14 19:19:42]

I've made some pretty sweeping changes, particularly to the way we use tables
(we don't anymore).  This cl could use another review.

[Cutch, 2014-03-14 19:45:19]

lgtm w/ comments

https://codereview.chromium.org/199363002/diff/60001/runtime/bin/vmservice/cl...
File runtime/bin/vmservice/client/lib/src/elements/function_ref.dart (right):

https://codereview.chromium.org/199363002/diff/60001/runtime/bin/vmservice/cl...
runtime/bin/vmservice/client/lib/src/elements/function_ref.dart:26: bool get
hasClass {
These are better as fields which you set in refChanged.

https://codereview.chromium.org/199363002/diff/60001/runtime/bin/vmservice/cl...
File runtime/bin/vmservice/client/lib/src/elements/function_ref.html (right):

https://codereview.chromium.org/199363002/diff/60001/runtime/bin/vmservice/cl...
runtime/bin/vmservice/client/lib/src/elements/function_ref.html:7: messing up
the output? -->
Maybe add some line breaks here. It's really hard to read on
codereview.chromium.org

[turnidge, 2014-03-17 17:43:26]

Committed patchset #6 manually as r33755 (presubmit successful).