runtime/bin/vmservice/client/lib/src/service/cache.dart - Issue 199363002: Rework library and class view pages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/vmservice/client/lib/src/service/cache.dart

Issue 199363002: Rework library and class view pages. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: merge Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/bin/vmservice/client/lib/src/service/cache.dart

diff --git a/runtime/bin/vmservice/client/lib/src/service/cache.dart b/runtime/bin/vmservice/client/lib/src/service/cache.dart

index 6feb94a2b468b4b8c46d1651c2c3d212158ce459..39e001d87a16731116108470b84886d9fbbb6d41 100644

--- a/runtime/bin/vmservice/client/lib/src/service/cache.dart

+++ b/runtime/bin/vmservice/client/lib/src/service/cache.dart

@@ -42,9 +42,9 @@ abstract class ServiceObjectCache<T extends ServiceObject> {

assert(cachesId(id));

T cached = _cache[id];

if (cached != null) {

- return new Future.value(cached);

+ return cached.load();

}

- return isolate.get(id).then(_addToCache);

+ return isolate.getDirect(id);

}

/// If [obj] is cached, return the cached object. Otherwise, upgrades [obj]