runtime/bin/vmservice/client/lib/src/elements/function_ref.html - Issue 199363002: Rework library and class view pages.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: runtime/bin/vmservice/client/lib/src/elements/function_ref.html

Issue 199363002: Rework library and class view pages. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: edits Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <head>	1 <head>

	2 <link rel="import" href="class_ref.html">

2 <link rel="import" href="service_ref.html">	3 <link rel="import" href="service_ref.html">

3 </head>	4 </head>

4 <polymer-element name="function-ref" extends="service-ref">	5 <polymer-element name="function-ref" extends="service-ref">

5 <template>	6 <!-- TODO(turnidge): Is there a way to add newlines to this without

6 <a title="{{ hoverText }}" href="{{ url }}">{{ name }}</a>	7 messing up the output? -->

7 </template>	8 <template><template if="{{ qualified && ref['parent'] == null && ref['class'][ 'name'] != '::' }}"><class-ref ref="{{ ref['class'] }}"></class-ref>.</template> <template if="{{ qualified && ref['parent'] != null }}"><function-ref ref="{{ re f['parent'] }}" qualified="{{ true }}"></function-ref>.</template><a href="{{ ur l }}">{{ name }}</a></template>
	Cutch 2014/03/13 18:16:40 Could you move this code into methods on FunctionR Could you move this code into methods on FunctionRefElement? It will make the template read better. <template if="{{ qualified && classQualified}}"> <class-ref ref="{{ ref['class'] }}"></class-ref>. </template> ...
	9

8 <script type="application/dart" src="function_ref.dart"></script>	10 <script type="application/dart" src="function_ref.dart"></script>

9 </polymer-element>	11 </polymer-element>

OLD	NEW