Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Issue 1985063004: Fix an edge case in dependency freshness checking. (Closed)

Created:
4 years, 7 months ago by nweiz
Modified:
4 years, 7 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/pub.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix an edge case in dependency freshness checking. If a path dependency had a dependency back on the root package, it would be detected as always stale because the root package isn't in the lockfile. This changes the check to always consider that fresh, since all dependencies on the root package are satisfied. Closes #1416 R=rnystrom@google.com Committed: https://github.com/dart-lang/pub/commit/488ab539770512a234f0a01b74882dcbb3f1a4da

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M lib/src/entrypoint.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M test/must_pub_get_test.dart View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
nweiz
4 years, 7 months ago (2016-05-17 17:58:56 UTC) #1
Bob Nystrom
lgtm https://codereview.chromium.org/1985063004/diff/1/lib/src/entrypoint.dart File lib/src/entrypoint.dart (right): https://codereview.chromium.org/1985063004/diff/1/lib/src/entrypoint.dart#newcode528 lib/src/entrypoint.dart:528: print("got fe"); Delete this. :)
4 years, 7 months ago (2016-05-17 18:10:20 UTC) #2
nweiz
Code review changes
4 years, 7 months ago (2016-05-17 18:26:13 UTC) #3
nweiz
https://codereview.chromium.org/1985063004/diff/1/lib/src/entrypoint.dart File lib/src/entrypoint.dart (right): https://codereview.chromium.org/1985063004/diff/1/lib/src/entrypoint.dart#newcode528 lib/src/entrypoint.dart:528: print("got fe"); On 2016/05/17 18:10:20, Bob Nystrom wrote: > ...
4 years, 7 months ago (2016-05-17 18:26:18 UTC) #4
nweiz
4 years, 7 months ago (2016-05-17 18:26:28 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
488ab539770512a234f0a01b74882dcbb3f1a4da (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698