Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Unified Diff: test/must_pub_get_test.dart

Issue 1985063004: Fix an edge case in dependency freshness checking. (Closed) Base URL: git@github.com:dart-lang/pub.git@master
Patch Set: Code review changes Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/entrypoint.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/must_pub_get_test.dart
diff --git a/test/must_pub_get_test.dart b/test/must_pub_get_test.dart
index 3ef503537d4ab2b1b6e6684a82626e10cfe41d6c..e1f71eb71351151126fe91a78ac435e41c4279b9 100644
--- a/test/must_pub_get_test.dart
+++ b/test/must_pub_get_test.dart
@@ -339,6 +339,25 @@ foo:http://example.com/
_runsSuccessfully();
});
+ // Regression test for #1416
+ group("a path dependency has a dependency on the root package", () {
+ setUp(() {
+ d.dir("foo", [
+ d.libPubspec("foo", "1.0.0", deps: {"myapp": "any"})
+ ]).create();
+
+ d.dir(appPath, [
+ d.appPubspec({"foo": {"path": "../foo"}})
+ ]).create();
+
+ pubGet();
+
+ _touch("pubspec.lock");
+ });
+
+ _runsSuccessfully();
+ });
+
group("the lockfile is newer than .packages, but they're up-to-date", () {
setUp(() {
d.dir(appPath, [
« no previous file with comments | « lib/src/entrypoint.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698