Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Unified Diff: lib/src/entrypoint.dart

Issue 1985063004: Fix an edge case in dependency freshness checking. (Closed) Base URL: git@github.com:dart-lang/pub.git@master
Patch Set: Code review changes Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/must_pub_get_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/entrypoint.dart
diff --git a/lib/src/entrypoint.dart b/lib/src/entrypoint.dart
index e0c6774a9c227945f26faff7fd8d843a585b76a8..0152926be06f375f9d77133da49fd124981d524f 100644
--- a/lib/src/entrypoint.dart
+++ b/lib/src/entrypoint.dart
@@ -536,6 +536,8 @@ class Entrypoint {
/// Returns whether the locked version of [dep] matches the dependency.
bool _isDependencyUpToDate(PackageDep dep) {
+ if (dep.name == root.name) return true;
+
var locked = lockFile.packages[dep.name];
if (locked == null) return false;
« no previous file with comments | « no previous file | test/must_pub_get_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698