Enables a SIMD test for ARM.

Enables a SIMD test for ARM.

Required adding the veorq, vmovq, and vdup instructions.

R=regis@google.com

Committed: https://code.google.com/p/dart/source/detail?r=25165

[regis, 2013-07-18 18:17:21]

LGTM

Nice!

https://codereview.chromium.org/19776007/diff/1/runtime/vm/assembler_arm.cc
File runtime/vm/assembler_arm.cc (right):

https://codereview.chromium.org/19776007/diff/1/runtime/vm/assembler_arm.cc#n...
runtime/vm/assembler_arm.cc:1331: ASSERT((sz != kDWord) && (sz != kSWord) && (sz
!= kWordPair));
Isn't the ASSERT redundant, since you have an UNREACHABLE in the default case
below?

https://codereview.chromium.org/19776007/diff/1/runtime/vm/simulator_arm.cc
File runtime/vm/simulator_arm.cc (right):

https://codereview.chromium.org/19776007/diff/1/runtime/vm/simulator_arm.cc#n...
runtime/vm/simulator_arm.cc:3036: if (imm4 & 1) {
Style: either ((imm4 & 1) == 1) or (((imm4 & 1) != 0)

https://codereview.chromium.org/19776007/diff/1/runtime/vm/simulator_arm.cc#n...
runtime/vm/simulator_arm.cc:3043: } else if (imm4 & 2) {
ditto

https://codereview.chromium.org/19776007/diff/1/runtime/vm/simulator_arm.cc#n...
runtime/vm/simulator_arm.cc:3050: } else if (imm4 & 4) {
ditto

[zra, 2013-07-18 18:32:08]

https://codereview.chromium.org/19776007/diff/1/runtime/vm/assembler_arm.cc
File runtime/vm/assembler_arm.cc (right):

https://codereview.chromium.org/19776007/diff/1/runtime/vm/assembler_arm.cc#n...
runtime/vm/assembler_arm.cc:1331: ASSERT((sz != kDWord) && (sz != kSWord) && (sz
!= kWordPair));
On 2013/07/18 18:17:21, regis wrote:
> Isn't the ASSERT redundant, since you have an UNREACHABLE in the default case
> below?

Yes. I removed the UNREACHABLE().

https://codereview.chromium.org/19776007/diff/1/runtime/vm/simulator_arm.cc
File runtime/vm/simulator_arm.cc (right):

https://codereview.chromium.org/19776007/diff/1/runtime/vm/simulator_arm.cc#n...
runtime/vm/simulator_arm.cc:3036: if (imm4 & 1) {
On 2013/07/18 18:17:21, regis wrote:
> Style: either ((imm4 & 1) == 1) or (((imm4 & 1) != 0)

Done.

https://codereview.chromium.org/19776007/diff/1/runtime/vm/simulator_arm.cc#n...
runtime/vm/simulator_arm.cc:3043: } else if (imm4 & 2) {
On 2013/07/18 18:17:21, regis wrote:
> ditto

Done.

https://codereview.chromium.org/19776007/diff/1/runtime/vm/simulator_arm.cc#n...
runtime/vm/simulator_arm.cc:3050: } else if (imm4 & 4) {
On 2013/07/18 18:17:21, regis wrote:
> ditto

Done.

[zra, 2013-07-18 18:40:33]

Committed patchset #2 manually as r25165 (presubmit successful).