Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 19773017: Adds ARM SIMD instructions. (Closed)

Created:
7 years, 5 months ago by zra
Modified:
7 years, 5 months ago
Reviewers:
regis
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Adds ARM SIMD instructions. vminqs, maxqs, vrecpeqs (Reciprocal estimate), vrecpsqs (Reciprocal Newton-Raphson step). R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=25245

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+290 lines, -0 lines) Patch
M runtime/vm/assembler_arm.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/vm/assembler_arm.cc View 1 2 1 chunk +21 lines, -0 lines 0 comments Download
M runtime/vm/assembler_arm_test.cc View 1 2 1 chunk +190 lines, -0 lines 0 comments Download
M runtime/vm/disassembler_arm.cc View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
M runtime/vm/simulator_arm.cc View 1 2 2 chunks +61 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
zra
7 years, 5 months ago (2013-07-19 20:23:30 UTC) #1
regis
LGTM
7 years, 5 months ago (2013-07-19 21:09:21 UTC) #2
zra
7 years, 5 months ago (2013-07-19 21:32:12 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r25245 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698