Adds more SIMD instructions for ARM.

Adds more SIMD instructions for ARM.

Adds the vnegqs, vabsqs, and vandq instructions.

Also reverts the increase in the number of floating point registers since it is causing crashes on hardware.

R=regis@google.com

Committed: https://code.google.com/p/dart/source/detail?r=25320

[regis, 2013-07-22 22:47:11]

LGTM

https://codereview.chromium.org/19493004/diff/8001/runtime/vm/constants_arm.h
File runtime/vm/constants_arm.h (right):

https://codereview.chromium.org/19493004/diff/8001/runtime/vm/constants_arm.h...
runtime/vm/constants_arm.h:15: #define VFPv3_D16
After you figure out the issue on the hardware, you can remove the todo and the
define, and always use 32 registers.

https://codereview.chromium.org/19493004/diff/8001/runtime/vm/constants_arm.h...
runtime/vm/constants_arm.h:168: static inline SRegister
EvenSRegisterOf(DRegister d) {
Assert that d is in range. It could be out of range, i.e. >= 16, for VFPv3_D32.

https://codereview.chromium.org/19493004/diff/8001/runtime/vm/constants_arm.h...
runtime/vm/constants_arm.h:172: static inline SRegister OddSRegisterOf(DRegister
d) {
ditto

https://codereview.chromium.org/19493004/diff/8001/runtime/vm/simulator_arm.cc
File runtime/vm/simulator_arm.cc (right):

https://codereview.chromium.org/19493004/diff/8001/runtime/vm/simulator_arm.c...
runtime/vm/simulator_arm.cc:937: if ((reg >= 0) && (reg < kNumberOfQRegisters))
{
Add a todo to replace the test by an assert after we support 16 Q registers
always.

[zra, 2013-07-22 23:20:09]

Thanks!

I will commit this change with VFPv3_D16 defined, and find/fix the VFPv3_D32 bug
in a subsequent CL.

https://codereview.chromium.org/19493004/diff/8001/runtime/vm/constants_arm.h
File runtime/vm/constants_arm.h (right):

https://codereview.chromium.org/19493004/diff/8001/runtime/vm/constants_arm.h...
runtime/vm/constants_arm.h:168: static inline SRegister
EvenSRegisterOf(DRegister d) {
On 2013/07/22 22:47:11, regis wrote:
> Assert that d is in range. It could be out of range, i.e. >= 16, for
VFPv3_D32.

I've added an assert under VFPv3_D32.

https://codereview.chromium.org/19493004/diff/8001/runtime/vm/constants_arm.h...
runtime/vm/constants_arm.h:172: static inline SRegister OddSRegisterOf(DRegister
d) {
On 2013/07/22 22:47:11, regis wrote:
> ditto

Same.

https://codereview.chromium.org/19493004/diff/8001/runtime/vm/simulator_arm.cc
File runtime/vm/simulator_arm.cc (right):

https://codereview.chromium.org/19493004/diff/8001/runtime/vm/simulator_arm.c...
runtime/vm/simulator_arm.cc:937: if ((reg >= 0) && (reg < kNumberOfQRegisters))
{
On 2013/07/22 22:47:11, regis wrote:
> Add a todo to replace the test by an assert after we support 16 Q registers
> always. 

Done.

[zra, 2013-07-22 23:26:16]

Committed patchset #3 manually as r25320 (presubmit successful).