Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(805)

Issue 19400003: Adds the vtbl ARM SIMD instruction. (Closed)

Created:
7 years, 5 months ago by zra
Modified:
7 years, 5 months ago
Reviewers:
regis
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Adds the vtbl ARM SIMD instruction. It is needed for the Float32x4ShuffleInstr of the intermediate language. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=25073

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+281 lines, -23 lines) Patch
M runtime/vm/assembler_arm.h View 2 chunks +7 lines, -0 lines 0 comments Download
M runtime/vm/assembler_arm.cc View 3 chunks +38 lines, -13 lines 0 comments Download
M runtime/vm/assembler_arm_test.cc View 1 chunk +172 lines, -0 lines 2 comments Download
M runtime/vm/disassembler_arm.cc View 4 chunks +26 lines, -9 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/vm/simulator_arm.cc View 1 1 chunk +36 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
zra
7 years, 5 months ago (2013-07-16 20:27:01 UTC) #1
regis
LGTM I think we left the RISC domain :-) https://codereview.chromium.org/19400003/diff/8001/runtime/vm/assembler_arm_test.cc File runtime/vm/assembler_arm_test.cc (right): https://codereview.chromium.org/19400003/diff/8001/runtime/vm/assembler_arm_test.cc#newcode2164 runtime/vm/assembler_arm_test.cc:2164: ...
7 years, 5 months ago (2013-07-16 20:57:14 UTC) #2
zra
Thanks! https://codereview.chromium.org/19400003/diff/8001/runtime/vm/assembler_arm_test.cc File runtime/vm/assembler_arm_test.cc (right): https://codereview.chromium.org/19400003/diff/8001/runtime/vm/assembler_arm_test.cc#newcode2164 runtime/vm/assembler_arm_test.cc:2164: ASSEMBLER_TEST_GENERATE(VtblX, assembler) { On 2013/07/16 20:57:14, regis wrote: ...
7 years, 5 months ago (2013-07-16 21:17:53 UTC) #3
zra
7 years, 5 months ago (2013-07-16 21:18:31 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r25073 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698