Change resolving of instance methods to check early for name mismatch.

Change resolving of instance methods to check early for name mismatch.

The names of actual arguments are checked at resolving time
for a mismatch instead of deferring this check to the function
prologue (emitted as part of the CopyParameters() prologue).

For example:

class A {
  foo({a:42}) => null;
}

main() {
  var a = new A();
  a.foo(b:123);  // noSuchMethod: no named parameter named "b".
}

This enables e.g. fast noSuchMethod invocation in the case
of a named argument mismatch.

It also makes the function prologue for instance functions that
use optional parameters shorter by omitting the check for a 
name mismatch there.

R=regis@google.com

Committed: https://code.google.com/p/dart/source/detail?r=25041

[Florian Schneider, 2013-07-15 14:22:40]

https://codereview.chromium.org/19200002/diff/1/runtime/vm/dart_api_impl.cc
File runtime/vm/dart_api_impl.cc (left):

https://codereview.chromium.org/19200002/diff/1/runtime/vm/dart_api_impl.cc#o...
runtime/vm/dart_api_impl.cc:2965: Resolver::kIsQualified));
This looks like a copy-paste mistake: enum is silently converted to int. It
worked because enum Resolver::kIsQualified == 0.

[regis, 2013-07-15 16:53:17]

LGTM

(Srdjan is ooo today)

[Florian Schneider, 2013-07-16 08:53:14]

On 2013/07/15 16:53:17, regis wrote:
> LGTM
> 
> (Srdjan is ooo today)

Thanks for reviewing.

[Florian Schneider, 2013-07-16 09:38:24]

Committed patchset #2 manually as r25041 (presubmit successful).