Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1609)

Unified Diff: runtime/vm/dart_entry.cc

Issue 19200002: Change resolving of instance methods to check early for name mismatch. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/dart_api_impl.cc ('k') | runtime/vm/flow_graph_compiler_arm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/dart_entry.cc
===================================================================
--- runtime/vm/dart_entry.cc (revision 25039)
+++ runtime/vm/dart_entry.cc (working copy)
@@ -138,12 +138,12 @@
// Now use the invocation mirror object and invoke NoSuchMethod.
const int kNumArguments = 2;
- const int kNumNamedArguments = 0;
+ ArgumentsDescriptor args_desc(
+ Array::Handle(ArgumentsDescriptor::New(kNumArguments)));
const Function& function = Function::Handle(
Resolver::ResolveDynamic(receiver,
Symbols::NoSuchMethod(),
- kNumArguments,
- kNumNamedArguments));
+ args_desc));
ASSERT(!function.IsNull());
const Array& args = Array::Handle(Array::New(kNumArguments));
args.SetAt(0, receiver);
@@ -389,12 +389,12 @@
RawObject* DartLibraryCalls::ToString(const Instance& receiver) {
const int kNumArguments = 1; // Receiver.
- const int kNumNamedArguments = 0; // None.
+ ArgumentsDescriptor args_desc(
+ Array::Handle(ArgumentsDescriptor::New(kNumArguments)));
const Function& function = Function::Handle(
Resolver::ResolveDynamic(receiver,
Symbols::toString(),
- kNumArguments,
- kNumNamedArguments));
+ args_desc));
ASSERT(!function.IsNull());
const Array& args = Array::Handle(Array::New(kNumArguments));
args.SetAt(0, receiver);
@@ -408,12 +408,12 @@
RawObject* DartLibraryCalls::Equals(const Instance& left,
const Instance& right) {
const int kNumArguments = 2;
- const int kNumNamedArguments = 0;
+ ArgumentsDescriptor args_desc(
+ Array::Handle(ArgumentsDescriptor::New(kNumArguments)));
const Function& function = Function::Handle(
Resolver::ResolveDynamic(left,
Symbols::EqualOperator(),
- kNumArguments,
- kNumNamedArguments));
+ args_desc));
ASSERT(!function.IsNull());
const Array& args = Array::Handle(Array::New(kNumArguments));
@@ -520,11 +520,12 @@
const Instance& key,
const Instance& value) {
const int kNumArguments = 3;
+ ArgumentsDescriptor args_desc(
+ Array::Handle(ArgumentsDescriptor::New(kNumArguments)));
const Function& function = Function::Handle(
Resolver::ResolveDynamic(map,
Symbols::AssignIndexToken(),
- kNumArguments,
- 0));
+ args_desc));
ASSERT(!function.IsNull());
const Array& args = Array::Handle(Array::New(kNumArguments));
args.SetAt(0, map);
« no previous file with comments | « runtime/vm/dart_api_impl.cc ('k') | runtime/vm/flow_graph_compiler_arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698