Change resolving of instance methods to check early for name mismatch.

runtime/vm/flow_graph_optimizer.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/flow_graph_optimizer.h"
 
 #include "vm/bit_vector.h"
 #include "vm/cha.h"
+#include "vm/dart_entry.h"
 #include "vm/flow_graph_builder.h"
 #include "vm/flow_graph_compiler.h"
 #include "vm/hash_map.h"
 #include "vm/il_printer.h"
 #include "vm/intermediate_language.h"
 #include "vm/object_store.h"
 #include "vm/parser.h"
 #include "vm/resolver.h"
 #include "vm/scopes.h"
 #include "vm/stack_frame.h"
@@ skipping 76 matching lines @@
   ASSERT(call->ic_data()->num_args_tested() <= call->ArgumentCount());
   for (intptr_t i = 0; i < call->ic_data()->num_args_tested(); i++) {
     intptr_t cid = call->PushArgumentAt(i)->value()->Type()->ToCid();
     class_ids.Add(cid);
   }
   // TODO(srdjan): Test for number of arguments checked greater than 1.
   if (class_ids.length() != 1) {
     return false;
   }
   if (class_ids[0] != kDynamicCid) {
-    const intptr_t num_named_arguments = call->argument_names().IsNull() ?
-        0 : call->argument_names().Length();
+    ArgumentsDescriptor args_desc(
+        Array::Handle(ArgumentsDescriptor::New(call->ArgumentCount(),
+                                               call->argument_names())));
     const Class& receiver_class = Class::Handle(
         Isolate::Current()->class_table()->At(class_ids[0]));
-    Function& function = Function::Handle();
-    function = Resolver::ResolveDynamicForReceiverClass(
-        receiver_class,
-        call->function_name(),
-        call->ArgumentCount(),
-        num_named_arguments);
+    const Function& function = Function::Handle(
+        Resolver::ResolveDynamicForReceiverClass(
+            receiver_class,
+            call->function_name(),
+            args_desc));
     if (function.IsNull()) {
       return false;
     }
     // Create new ICData, do not modify the one attached to the instruction
     // since it is attached to the assembly instruction itself.
     // TODO(srdjan): Prevent modification of ICData object that is
     // referenced in assembly code.
     ICData& ic_data = ICData::ZoneHandle(ICData::New(
         flow_graph_->parsed_function().function(),
         call->function_name(),
@@ skipping 2524 matching lines @@
      compare->left()->Type()->ToNullableCid();
 
   if (receiver_cid == kDynamicCid) {
     return false;
   }
 
   const Class& receiver_class = Class::Handle(
       Isolate::Current()->class_table()->At(receiver_cid));
 
   // Resolve equality operator.
+  const intptr_t kNumArgs = 2;
+  ArgumentsDescriptor args_desc(
+      Array::Handle(ArgumentsDescriptor::New(kNumArgs)));
   const Function& function = Function::Handle(
       Resolver::ResolveDynamicForReceiverClass(
           receiver_class,
           Symbols::EqualOperator(),
-          2,
-          0));
+          args_desc));
 
   if (function.IsNull()) {
     return false;
   }
 
   // Default equality operator declared on the Object class just calls
   // identical.
   return (Class::Handle(function.Owner()).id() == kInstanceCid);
 }
 
@@ skipping 4506 matching lines @@
 
   // Insert materializations at environment uses.
   const Class& cls = Class::Handle(alloc->constructor().Owner());
   for (intptr_t i = 0; i < exits.length(); i++) {
     CreateMaterializationAt(exits[i], alloc, cls, *fields);
   }
 }
 
 
 }  // namespace dart