Support new malformed types semantics.

Support new malformed types semantics.

BUG=http://dartbug.com/8325,http://dartbug.com/9056
R=karlklose@google.com

Committed: https://code.google.com/p/dart/source/detail?r=25553

[karlklose, 2013-07-19 11:45:40]

LGTM with comments.  Thanks for the cleanup of the type resolution!

https://codereview.chromium.org/19097003/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/dart_types.dart (right):

https://codereview.chromium.org/19097003/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/dart_types.dart:112: /**
Use `///` for these short comments.

https://codereview.chromium.org/19097003/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/js_backend/backend.dart (right):

https://codereview.chromium.org/19097003/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/js_backend/backend.dart:108: class
MalformedCheckedModeHelper extends CheckedModeHelper {
This should be AmbiguousTypeCheckedModeHelper.

https://codereview.chromium.org/19097003/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart
(right):

https://codereview.chromium.org/19097003/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart:1088: bool
get isDynamic =>_type.isDynamic;
Space after arrow.

https://codereview.chromium.org/19097003/diff/1/tests/co19/co19-dart2dart.status
File tests/co19/co19-dart2dart.status (left):

https://codereview.chromium.org/19097003/diff/1/tests/co19/co19-dart2dart.sta...
tests/co19/co19-dart2dart.status:98: Language/03_Overview/2_Privacy_A01_t06:
Fail # New import syntax
Why is this now passing?

https://codereview.chromium.org/19097003/diff/1/tests/co19/co19-dart2js.status
File tests/co19/co19-dart2js.status (left):

https://codereview.chromium.org/19097003/diff/1/tests/co19/co19-dart2js.statu...
tests/co19/co19-dart2js.status:136: 
Leave this line in.

https://codereview.chromium.org/19097003/diff/1/tests/language/is_not_class2_...
File tests/language/is_not_class2_test.dart (right):

https://codereview.chromium.org/19097003/diff/1/tests/language/is_not_class2_...
tests/language/is_not_class2_test.dart:18: if (a is aa) { // static warning
Make it a multitest to test for the warning.

https://codereview.chromium.org/19097003/diff/1/tests/language/language.status
File tests/language/language.status (right):

https://codereview.chromium.org/19097003/diff/1/tests/language/language.statu...
tests/language/language.status:27: 
In this file we only use one newline to separate the blocks.

https://codereview.chromium.org/19097003/diff/1/tests/language/language.statu...
tests/language/language.status:83: is_not_class2_test: Fail # Issue 9055
Are all of these copied into one place or are the tests changed?

https://codereview.chromium.org/19097003/diff/1/tests/language/malformed_test...
File tests/language/malformed_test.dart (right):

https://codereview.chromium.org/19097003/diff/1/tests/language/malformed_test...
tests/language/malformed_test.dart:48: Expect.throws(() => v as
List<prefix.Unresolved<int>>, (e) => e is CastError);
Long line.

https://codereview.chromium.org/19097003/diff/1/tests/language/malformed_test...
tests/language/malformed_test.dart:53: checkIsMapDynamic(bool first, second, var
v) {
bool second.

https://codereview.chromium.org/19097003/diff/1/tests/language/malformed_test...
tests/language/malformed_test.dart:54: Expect.equals(first, v is Map<String,
int> && v is Map<int, int>);
You could use 'v is Map<String, Object> && v is Map<int, Object>' and 'v is
Map<Object, int> && v is Map<Object, String>', so the method is not
unnecessarily restricted.

https://codereview.chromium.org/19097003/diff/1/tests/language/on_catch_malfo...
File tests/language/on_catch_malformed_type_test.dart (right):

https://codereview.chromium.org/19097003/diff/1/tests/language/on_catch_malfo...
tests/language/on_catch_malformed_type_test.dart:27: // it throws a type error.
Don't you have to test for the TypeError case?

https://codereview.chromium.org/19097003/diff/1/tests/language/prefix16_test....
File tests/language/prefix16_test.dart (right):

https://codereview.chromium.org/19097003/diff/1/tests/language/prefix16_test....
tests/language/prefix16_test.dart:29: // Malformed myFunc treated as (dynamic)
=> dynamic.
Do we have tests for functions with malformed and wellformed parameters?

https://codereview.chromium.org/19097003/diff/1/tests/language/prefix16_test....
tests/language/prefix16_test.dart:45: // Type error in checked mode only.
Update comment.  You could also fail directly in the catch-block.

https://codereview.chromium.org/19097003/diff/1/tests/language/type_variable_...
File tests/language/type_variable_scope2_test.dart (right):

https://codereview.chromium.org/19097003/diff/1/tests/language/type_variable_...
tests/language/type_variable_scope2_test.dart:25: // No type error in production
nor checked mode.
You could fail in the catch-block.

[Johnni Winther, 2013-07-29 09:59:48]

https://codereview.chromium.org/19097003/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/dart_types.dart (right):

https://codereview.chromium.org/19097003/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/dart_types.dart:112: /**
On 2013/07/19 11:45:40, karlklose wrote:
> Use `///` for these short comments.

Done.

https://codereview.chromium.org/19097003/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/js_backend/backend.dart (right):

https://codereview.chromium.org/19097003/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/js_backend/backend.dart:108: class
MalformedCheckedModeHelper extends CheckedModeHelper {
On 2013/07/19 11:45:40, karlklose wrote:
> This should be AmbiguousTypeCheckedModeHelper.

Done.

https://codereview.chromium.org/19097003/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart
(right):

https://codereview.chromium.org/19097003/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart:1088: bool
get isDynamic =>_type.isDynamic;
On 2013/07/19 11:45:40, karlklose wrote:
> Space after arrow.

Done.

https://codereview.chromium.org/19097003/diff/1/tests/co19/co19-dart2dart.status
File tests/co19/co19-dart2dart.status (left):

https://codereview.chromium.org/19097003/diff/1/tests/co19/co19-dart2dart.sta...
tests/co19/co19-dart2dart.status:98: Language/03_Overview/2_Privacy_A01_t06:
Fail # New import syntax
On 2013/07/19 11:45:40, karlklose wrote:
> Why is this now passing?

We now give a runtime error instead of a compile-time error on ambiguous types
in type tests.

https://codereview.chromium.org/19097003/diff/1/tests/co19/co19-dart2js.status
File tests/co19/co19-dart2js.status (left):

https://codereview.chromium.org/19097003/diff/1/tests/co19/co19-dart2js.statu...
tests/co19/co19-dart2js.status:136: 
On 2013/07/19 11:45:40, karlklose wrote:
> Leave this line in.

Done.

https://codereview.chromium.org/19097003/diff/1/tests/language/is_not_class2_...
File tests/language/is_not_class2_test.dart (right):

https://codereview.chromium.org/19097003/diff/1/tests/language/is_not_class2_...
tests/language/is_not_class2_test.dart:18: if (a is aa) { // static warning
On 2013/07/19 11:45:40, karlklose wrote:
> Make it a multitest to test for the warning.

We don't test warnings in multitests.

https://codereview.chromium.org/19097003/diff/1/tests/language/language.status
File tests/language/language.status (right):

https://codereview.chromium.org/19097003/diff/1/tests/language/language.statu...
tests/language/language.status:27: 
On 2013/07/19 11:45:40, karlklose wrote:
> In this file we only use one newline to separate the blocks.

Done.

https://codereview.chromium.org/19097003/diff/1/tests/language/language.statu...
tests/language/language.status:83: is_not_class2_test: Fail # Issue 9055
On 2013/07/19 11:45:40, karlklose wrote:
> Are all of these copied into one place or are the tests changed?

All tests have been updated to follow the new spec.

https://codereview.chromium.org/19097003/diff/1/tests/language/malformed_test...
File tests/language/malformed_test.dart (right):

https://codereview.chromium.org/19097003/diff/1/tests/language/malformed_test...
tests/language/malformed_test.dart:48: Expect.throws(() => v as
List<prefix.Unresolved<int>>, (e) => e is CastError);
On 2013/07/19 11:45:40, karlklose wrote:
> Long line.

Done.

https://codereview.chromium.org/19097003/diff/1/tests/language/malformed_test...
tests/language/malformed_test.dart:53: checkIsMapDynamic(bool first, second, var
v) {
On 2013/07/19 11:45:40, karlklose wrote:
> bool second.

Done.

https://codereview.chromium.org/19097003/diff/1/tests/language/malformed_test...
tests/language/malformed_test.dart:54: Expect.equals(first, v is Map<String,
int> && v is Map<int, int>);
On 2013/07/19 11:45:40, karlklose wrote:
> You could use 'v is Map<String, Object> && v is Map<int, Object>' and 'v is
> Map<Object, int> && v is Map<Object, String>', so the method is not
> unnecessarily restricted.

Done.

https://codereview.chromium.org/19097003/diff/1/tests/language/on_catch_malfo...
File tests/language/on_catch_malformed_type_test.dart (right):

https://codereview.chromium.org/19097003/diff/1/tests/language/on_catch_malfo...
tests/language/on_catch_malformed_type_test.dart:27: // it throws a type error.
On 2013/07/19 11:45:40, karlklose wrote:
> Don't you have to test for the TypeError case?

No error is thrown. Comment updated.

https://codereview.chromium.org/19097003/diff/1/tests/language/prefix16_test....
File tests/language/prefix16_test.dart (right):

https://codereview.chromium.org/19097003/diff/1/tests/language/prefix16_test....
tests/language/prefix16_test.dart:29: // Malformed myFunc treated as (dynamic)
=> dynamic.
On 2013/07/19 11:45:40, karlklose wrote:
> Do we have tests for functions with malformed and wellformed parameters?

Extended this test.

https://codereview.chromium.org/19097003/diff/1/tests/language/prefix16_test....
tests/language/prefix16_test.dart:45: // Type error in checked mode only.
On 2013/07/19 11:45:40, karlklose wrote:
> Update comment.  You could also fail directly in the catch-block.

Done.

https://codereview.chromium.org/19097003/diff/1/tests/language/type_variable_...
File tests/language/type_variable_scope2_test.dart (right):

https://codereview.chromium.org/19097003/diff/1/tests/language/type_variable_...
tests/language/type_variable_scope2_test.dart:25: // No type error in production
nor checked mode.
On 2013/07/19 11:45:40, karlklose wrote:
> You could fail in the catch-block.

Done.

[Johnni Winther, 2013-07-29 10:21:09]

Committed patchset #5 manually as r25553 (presubmit successful).