sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart - Issue 19097003: Support new malformed types semantics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart

Issue 19097003: Support new malformed types semantics. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Fix unittests. Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart ('k') | sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart

diff --git a/sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart b/sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart

index 3f215972b82eb3cb3bcc2a7e45e6f247a3ec0404..4c72122f90c2c362031030285533b6a9ac0e5144 100644

--- a/sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart

+++ b/sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart

@@ -631,7 +631,7 @@ class TypeRepresentationGenerator extends DartTypeVisitor {

addProperty(namer.functionTypeTag(), name);

if (type.returnType.isVoid) {

addProperty(namer.functionTypeVoidReturnTag(), js('true'));

- } else if (!type.returnType.isDynamic) {

+ } else if (!type.returnType.treatAsDynamic) {

addProperty(namer.functionTypeReturnTypeTag(), visit(type.returnType));

}

if (!type.parameterTypes.isEmpty) {