Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: tests/language/prefix16_test.dart

Issue 19097003: Support new malformed types semantics. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fix unittests. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/language/on_catch_malformed_type_test.dart ('k') | tests/language/prefix9_negative_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/language/prefix16_test.dart
diff --git a/tests/language/prefix16_test.dart b/tests/language/prefix16_test.dart
index 4fca6b0c0c386aaac1090e0d3ea45e25b0e602cc..98e4f0d053aeab228234058145ccffa36ecbb5b7 100644
--- a/tests/language/prefix16_test.dart
+++ b/tests/language/prefix16_test.dart
@@ -2,17 +2,16 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
//
-// Unresolved imported symbols are handled differently in production mode and
-// check modes. In this test, the function myFunc is malformed, because
+// Unresolved imported symbols are treated as dynamic
+// In this test, the function myFunc contains malformed types because
// lib12.Library13 is not resolved.
-// In checked mode, the assignment type check throws a run time type error.
-// In production, no assignment type checks are performed.
library Prefix16NegativeTest.dart;
import "package:expect/expect.dart";
import "library12.dart" as lib12;
typedef lib12.Library13 myFunc(lib12.Library13 param);
+typedef lib12.Library13 myFunc2(lib12.Library13 param, int i);
isCheckedMode() {
try {
@@ -28,6 +27,7 @@ main() {
{
bool got_type_error = false;
try {
+ // Malformed myFunc treated as (dynamic) => dynamic.
myFunc i = 0;
} on TypeError catch (error) {
got_type_error = true;
@@ -36,14 +36,27 @@ main() {
Expect.isTrue(got_type_error == isCheckedMode());
}
{
- bool got_type_error = false;
try {
- // In production mode, malformed myFunc is mapped to (dynamic) => dynamic.
+ // Malformed myFunc treated as (dynamic) => dynamic.
Expect.isTrue(((int x) => x) is myFunc);
} on TypeError catch (error) {
- got_type_error = true;
+ Expect.fail();
+ }
+ }
+ {
+ try {
+ // Malformed myFunc2 treated as (dynamic,int) => dynamic.
+ Expect.isTrue(((int x, int y) => x) is myFunc2);
+ } on TypeError catch (error) {
+ Expect.fail();
+ }
+ }
+ {
+ try {
+ // Malformed myFunc2 treated as (dynamic,int) => dynamic.
+ Expect.isFalse(((int x, String y) => x) is myFunc2);
+ } on TypeError catch (error) {
+ Expect.fail();
}
- // Type error in checked mode only.
- Expect.isTrue(got_type_error == isCheckedMode());
}
}
« no previous file with comments | « tests/language/on_catch_malformed_type_test.dart ('k') | tests/language/prefix9_negative_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698