Issue 189583005: Fix a bug in barback caused by r33408.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 189583005: Fix a bug in barback caused by r33408. (Closed)

Created:
6 years, 9 months ago by nweiz

Modified:
6 years, 9 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Fix a bug in barback caused by r33408. It turns out barback didn't have any tests for removing a transformer group (oops!), and r33408 introduced a bug there. This fixes that bug and adds a test. R=rnystrom@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=33410

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -1 line)			Patch
	M	pkg/barback/lib/src/phase.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	pkg/barback/test/package_graph/group_test.dart	View		1 chunk	+15 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

nweiz

On 2014/03/07 01:55:16, nweiz wrote: TBRing this for the bots.

6 years, 9 months ago (2014-03-07 01:55:44 UTC) #2

nweiz

Committed patchset #1 manually as r33410 (presubmit successful).

6 years, 9 months ago (2014-03-07 01:55:54 UTC) #3

Message was sent while issue was closed.

lgtm