Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Side by Side Diff: pkg/barback/test/package_graph/group_test.dart

Issue 189583005: Fix a bug in barback caused by r33408. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « pkg/barback/lib/src/phase.dart ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library barback.test.package_graph.group_test; 5 library barback.test.package_graph.group_test;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 8
9 import 'package:barback/barback.dart'; 9 import 'package:barback/barback.dart';
10 import 'package:scheduled_test/scheduled_test.dart'; 10 import 'package:scheduled_test/scheduled_test.dart';
(...skipping 348 matching lines...) Expand 10 before | Expand all | Expand 10 after
359 [group, new RewriteTransformer("a", "z")] 359 [group, new RewriteTransformer("a", "z")]
360 ]); 360 ]);
361 expectAsset("app|foo.c", "foo.b.c"); 361 expectAsset("app|foo.c", "foo.b.c");
362 expectAsset("app|foo.z", "foo.z"); 362 expectAsset("app|foo.z", "foo.z");
363 buildShouldSucceed(); 363 buildShouldSucceed();
364 364
365 expect(rewrite1.numRuns, completion(equals(1))); 365 expect(rewrite1.numRuns, completion(equals(1)));
366 expect(rewrite2.numRuns, completion(equals(1))); 366 expect(rewrite2.numRuns, completion(equals(1)));
367 }); 367 });
368 368
369 test("doesn't run transforms in a removed group", () {
370 var rewrite1 = new RewriteTransformer("a", "b");
371 var rewrite2 = new RewriteTransformer("b", "c");
372 var group = new TransformerGroup([[rewrite1], [rewrite2]]);
373 initGraph(["app|foo.a"], {"app": [[group]]});
374
375 updateSources(["app|foo.a"]);
376 expectAsset("app|foo.c", "foo.b.c");
377 buildShouldSucceed();
378
379 updateTransformers("app", []);
380 expectNoAsset("app|foo.c");
381 buildShouldSucceed();
382 });
383
369 test("doesn't pass through an input that's overwritten by an added group", 384 test("doesn't pass through an input that's overwritten by an added group",
370 () { 385 () {
371 var rewrite = new RewriteTransformer("x", "z"); 386 var rewrite = new RewriteTransformer("x", "z");
372 initGraph(["app|foo.a"], {"app": [[rewrite]]}); 387 initGraph(["app|foo.a"], {"app": [[rewrite]]});
373 388
374 updateSources(["app|foo.a"]); 389 updateSources(["app|foo.a"]);
375 expectAsset("app|foo.a", "foo"); 390 expectAsset("app|foo.a", "foo");
376 buildShouldSucceed(); 391 buildShouldSucceed();
377 392
378 updateTransformers("app", [ 393 updateTransformers("app", [
(...skipping 20 matching lines...) Expand all
399 new TransformerGroup([ 414 new TransformerGroup([
400 [new RewriteTransformer("a", "b")], 415 [new RewriteTransformer("a", "b")],
401 [new RewriteTransformer("b", "c")] 416 [new RewriteTransformer("b", "c")]
402 ]), 417 ]),
403 new RewriteTransformer("x", "c") 418 new RewriteTransformer("x", "c")
404 ]]}); 419 ]]});
405 updateSources(["app|foo.a", "app|foo.x"]); 420 updateSources(["app|foo.a", "app|foo.x"]);
406 buildShouldFail([isAssetCollisionException("app|foo.c")]); 421 buildShouldFail([isAssetCollisionException("app|foo.c")]);
407 }); 422 });
408 } 423 }
OLDNEW
« no previous file with comments | « pkg/barback/lib/src/phase.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698