Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Side by Side Diff: pkg/barback/lib/src/phase.dart

Issue 189583005: Fix a bug in barback caused by r33408. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | pkg/barback/test/package_graph/group_test.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library barback.phase; 5 library barback.phase;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 8
9 import 'asset_cascade.dart'; 9 import 'asset_cascade.dart';
10 import 'asset_id.dart'; 10 import 'asset_id.dart';
(...skipping 307 matching lines...) Expand 10 before | Expand all | Expand 10 after
318 // be re-run and will consume the output from the new final phase. 318 // be re-run and will consume the output from the new final phase.
319 output.removeListeners(); 319 output.removeListeners();
320 } 320 }
321 return _next; 321 return _next;
322 } 322 }
323 323
324 /// Mark this phase as removed. 324 /// Mark this phase as removed.
325 /// 325 ///
326 /// This will remove all the phase's outputs and all following phases. 326 /// This will remove all the phase's outputs and all following phases.
327 void remove() { 327 void remove() {
328 _previous._next = null; 328 if (_previous != null) _previous._next = null;
329 removeFollowing(); 329 removeFollowing();
330 for (var input in _inputs.values.toList()) { 330 for (var input in _inputs.values.toList()) {
331 input.remove(); 331 input.remove();
332 } 332 }
333 for (var group in _groups.values) { 333 for (var group in _groups.values) {
334 group.remove(); 334 group.remove();
335 } 335 }
336 _onAssetController.close(); 336 _onAssetController.close();
337 _onLogPool.close(); 337 _onLogPool.close();
338 } 338 }
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
398 assert(asset.state.isDirty); 398 assert(asset.state.isDirty);
399 asset.force(); 399 asset.force();
400 asset.whenStateChanges().then((state) { 400 asset.whenStateChanges().then((state) {
401 if (state.isRemoved) return getOutput(asset.id); 401 if (state.isRemoved) return getOutput(asset.id);
402 return asset; 402 return asset;
403 }).then(request.complete).catchError(request.completeError); 403 }).then(request.complete).catchError(request.completeError);
404 } 404 }
405 405
406 String toString() => "phase $_location.$_index"; 406 String toString() => "phase $_location.$_index";
407 } 407 }
OLDNEW
« no previous file with comments | « no previous file | pkg/barback/test/package_graph/group_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698