Issue 18737004: List class was not initialized properly (it has type parameters). Do not preinitialize it incorrect…

Issue 18737004: List class was not initialized properly (it has type parameters). Do not preinitialize it incorrect… (Closed)

Created:
7 years, 5 months ago by srdjan

Modified:
7 years, 5 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

List class was not initialized properly (it has type parameters). Do not preinitialize it incorrectly, instead let it be loaded and finalized the normal way. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=24922

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -25 lines)			Patch
M	runtime/vm/dart_api_impl.cc	View	1 2 3	1 chunk	+4 lines, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler.h	View	1 2 3	2 chunks	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler.cc	View	1 2 3	1 chunk	+4 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_arm.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler_mips.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/object.h	View	1 2 3	1 chunk	+0 lines, -3 lines	0 comments	Download
M	runtime/vm/object.cc	View	1 2 3	2 chunks	+0 lines, -11 lines	0 comments	Download
M	runtime/vm/object_store.h	View	1 2 3	2 chunks	+0 lines, -4 lines	0 comments	Download
M	runtime/vm/object_store.cc	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

siva

lgtm https://codereview.chromium.org/18737004/diff/19002/runtime/vm/dart_api_impl.cc File runtime/vm/dart_api_impl.cc (right): https://codereview.chromium.org/18737004/diff/19002/runtime/vm/dart_api_impl.cc#newcode60 runtime/vm/dart_api_impl.cc:60: Class::Handle(core_lib.LookupClass(Symbols::List())); ASSERT(!list_class.IsNull());

7 years, 5 months ago (2013-07-11 00:21:58 UTC) #2

srdjan

https://codereview.chromium.org/18737004/diff/19002/runtime/vm/dart_api_impl.cc File runtime/vm/dart_api_impl.cc (right): https://codereview.chromium.org/18737004/diff/19002/runtime/vm/dart_api_impl.cc#newcode60 runtime/vm/dart_api_impl.cc:60: Class::Handle(core_lib.LookupClass(Symbols::List())); On 2013/07/11 00:21:58, siva wrote: > ASSERT(!list_class.IsNull()); Done.

7 years, 5 months ago (2013-07-11 17:05:44 UTC) #3

srdjan

7 years, 5 months ago (2013-07-11 17:32:22 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 manually as r24922 (presubmit successful).

Expand Messages | Collapse Messages